selectUtxos used typeof findIndex === 'undefined' to detect a missing required outpoint, but findIndex returns -1. A missing UTXO was therefore spliced as undefined and later crashed on .sats (seen when auto-consolidating after an oversized tx). Treat -1 as missing, guard the splice result, bump to 6.1.2.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABC5f093d2cdb0d: [ecash-wallet] Throw when requiredUtxo is missing from spendableUtxos
- cd modules/ecash-wallet && npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) We don't ship debt; we refinance it into tests.
────────────────────────────────────────
Review complete
No findings ✔
4 files reviewed:
- modules/ecash-wallet/README.md
- modules/ecash-wallet/package.json
- modules/ecash-wallet/src/wallet.test.ts
- modules/ecash-wallet/src/wallet.ts
────────────────────────────────────────
Comment Actions
Drop the JS findIndex comment and the redundant post-splice undefined check. The -1 guard is the fix.
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) CUDA: Carrot Utilization for Debugging Acceleration.
────────────────────────────────────────
Review complete
No findings ✔
4 files reviewed:
- modules/ecash-wallet/README.md
- modules/ecash-wallet/package.json
- modules/ecash-wallet/src/wallet.test.ts
- modules/ecash-wallet/src/wallet.ts
────────────────────────────────────────