This codebase is still missing the Electrum backport introducing the logger. Keep using the poorly named print_error method until we actually have a logger (issue introduced by D20473)
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABCfc1e61a0c70e: [electrum] fix logging in json_db.py
Run the test plan of D20529 without the fix introduced by this diff, in verbose mode:
QT_API=pyqt6 ~/electrum-abc -v
Check for the log line.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) Design with contracts. Use contracts to document and verify that code does no more and no less than it claims to do.
────────────────────────────────────────
Review complete
No findings ✔
1 file reviewed:
- electrum/electrumabc/json_db.py
────────────────────────────────────────