Hardware wallets don't have a get_private_key method. Return early to avoid an error popup with a python traceback.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC4f71d16ccbe6: [electrum] fix an error when opening the delegation editor with a hardware…
After signing a proof with a hardware wallet, click "generate delagation" in the proof editor. Check that there is no longer an error popup.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) Don't be a slave to formal methods. Don't blindly adopt any technique without putting it into the context of your development practices and capabilities.
────────────────────────────────────────
Review complete
No findings ✔
1 file reviewed:
- electrum/electrumabc_gui/qt/avalanche/delegation_editor.py
────────────────────────────────────────