Disable Telegram link previews so explorer OG images are not
attached (same link_preview_options as ecash-herald). Token amounts use
toLocaleString grouping, each tokenId is linked once (Pair line),
exchange rates use 4 significant figures, and settle ops messages include
constant-product price impact vs spot.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC0a704c5a875a: [alp-dex] Tighten Telegram ops swap messages
- cd apps/alp-dex && pnpm test
- Confirm sendTelegramOps extra includes link_preview_options.is_disabled
- Confirm a success ops message: one explorer link per tokenId, grouped qtys (e.g. 2,171,731.97), 4-sig-fig rate (147656 → 147,700), and a Price impact line
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) Time zones: the final boss of software.
────────────────────────────────────────
Review complete
No findings ✔
5 files reviewed:
- apps/alp-dex/src/ops/telegram.ts
- apps/alp-dex/src/ops/telegramMessages.ts
- apps/alp-dex/src/routes/settle.ts
- apps/alp-dex/test/telegram.test.ts
- apps/alp-dex/test/telegramMessages.test.ts
────────────────────────────────────────