Differential D20546
cmake: use the tar.gz rather than git clone for corrosion Authored by PiRK on Sep 3 2026, 08:25. Project Tags None Referenced Files
Subscribers Tokens
Details
Github currently implement an anti-DoS mitigation with a rate limit for unhautenticated HTTPS git clone. This breaks our cmake flow when building Chronik. Use the tar.gz archive instead of git clone. The tar.gz download is also usually faster than a git clone. Use the provided guix package for the reproducible build Depends on D20567 cmake .. -GNinja -DBUILD_CHRONIK=1 rm -Rf ./* cmake .. -GNinja -DBUILD_CHRONIK=1 guix-build
Diff Detail
Event Timeline
Comment Actions Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Tail of the build log: [416/604] Linking CXX executable src/bitcoin-tx [417/604] Linking C executable src/secp256k1/bench [418/604] Linking C executable src/secp256k1/examples/ecdsa_example [419/604] Linking C executable src/secp256k1/examples/ecdh_example [420/604] Linking C executable src/secp256k1/examples/schnorr_example [421/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o [422/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o [423/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o [424/604] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o [425/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o [426/604] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o [427/604] Linking C executable src/secp256k1/internal-bench [428/604] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o [429/604] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o [430/604] Linking C executable src/secp256k1/ecmult-bench [431/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o [432/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o [433/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o [434/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o [435/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o [436/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o [437/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o [438/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o [439/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o [440/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o [441/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o [442/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o [443/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o [444/604] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o [445/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o [446/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o [447/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o [448/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o [449/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o [450/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o [451/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o [452/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o [453/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o [454/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o [455/604] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o [456/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o [457/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o [458/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o [459/604] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o [460/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o [461/604] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o [462/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o [463/604] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o [464/604] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o [465/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o [466/604] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o [467/604] Linking CXX executable src/iguana/iguana [468/604] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o [469/604] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o [470/604] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o [471/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o [472/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o [473/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o ninja: build stopped: cannot make progress due to previous errors. Build build-clang-tidy failed with exit code 1 Comment Actions Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed. Diff : committed changes only (\(\ ──────────────────────────────────────────────────────────────────────── major [Functional Correctness] → ]8;;vscode://file//work/cmake/modules/RustHelper.cmake:6cmake/modules/RustHelper.cmake:6-8]8;; Raise the CMake minimum to 3.24 or gate DOWNLOAD_EXTRACT_TIMESTAMP. Corrosion v0.6 requires CMake 3.22, but DOWNLOAD_EXTRACT_TIMESTAMP was introduced in CMake 3.24. In CMake 3.22 and 3.23, ExternalProject_Add treats the unknown option and TRUE as additional URL_HASH values, then fails hash validation. Raise the project minimum to 3.24, or conditionally omit this option for older versions. ──────────────────────────────────────── Major 1 1 file reviewed:
──────────────────────────────────────── Print all AI prompts: coderabbit review --show-prompts Comment Actions Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Tail of the build log: [416/604] Linking CXX static library src/libcommon.a [417/604] Linking CXX shared library src/libbitcoinconsensus.so.0.33.11 [418/604] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so [419/604] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o [420/604] Linking C executable src/secp256k1/ecmult-bench [421/604] Linking CXX executable src/bitcoin-cli [422/604] Linking C executable src/secp256k1/bench [423/604] Linking C executable src/secp256k1/examples/ecdsa_example [424/604] Linking C executable src/secp256k1/examples/schnorr_example [425/604] Linking C executable src/secp256k1/examples/ecdh_example [426/604] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o [427/604] Linking CXX executable src/bitcoin-tx [428/604] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o [429/604] Linking C executable src/secp256k1/internal-bench [430/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o [431/604] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o [432/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o [433/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o [434/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o [435/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o [436/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o [437/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o [438/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o [439/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o [440/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o [441/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o [442/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o [443/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o [444/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o [445/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o [446/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o [447/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o [448/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o [449/604] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o [450/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o [451/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o [452/604] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o [453/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o [454/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o [455/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o [456/604] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o [457/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o [458/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o [459/604] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o [460/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o [461/604] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o [462/604] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o [463/604] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o [464/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o [465/604] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o [466/604] Linking CXX executable src/iguana/iguana [467/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o [468/604] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o [469/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o [470/604] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o [471/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o [472/604] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o [473/604] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o ninja: build stopped: cannot make progress due to previous errors. Build build-clang-tidy failed with exit code 1 Comment Actions Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.
Tail of the build log: [416/605] Linking CXX shared library src/libbitcoinconsensus.so.0.33.11 [417/605] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o [418/605] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so [419/605] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o [420/605] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o [421/605] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o [422/605] Linking CXX executable src/bitcoin-cli [423/605] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o [424/605] Linking C executable src/secp256k1/ecmult-bench [425/605] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o [426/605] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o [427/605] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o [428/605] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o [429/605] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o [430/605] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o [431/605] Linking CXX executable src/bitcoin-tx [432/605] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o [433/605] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o [434/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o [435/605] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o [436/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o [437/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o [438/605] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o [439/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o [440/605] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o [441/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o [442/605] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o [443/605] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o [444/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o [445/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o [446/605] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o [447/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o [448/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o [449/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o [450/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o [451/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o [452/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o [453/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o [454/605] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o [455/605] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o [456/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o [457/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o [458/605] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o [459/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o [460/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o [461/605] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o [462/605] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o [463/605] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o [464/605] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o [465/605] Linking CXX executable src/iguana/iguana [466/605] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o [467/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o [468/605] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o [469/605] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o [470/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o [471/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o [472/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o [473/605] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o ninja: build stopped: cannot make progress due to previous errors. Build build-chronik failed with exit code 1 Comment Actions don't bump corrosion in this diff (v0.6 breaks the build, we can bump to v0.5.2 in another diff if we need a bugfix for MSVC) Comment Actions Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed. Diff : committed changes only (\(\ ──────────────────────────────────────── 1 file reviewed:
──────────────────────────────────────── Comment Actions Build Bitcoin ABC Diffs / Diff Testing (guix-linux) failed.
Tail of the build log: -- Found Event component pthreads: /bitcoin/depends/x86_64-linux-gnu/lib/libevent_pthreads.a -- Found Event: /bitcoin/depends/x86_64-linux-gnu/include (found suitable version "99.99.99", minimum required is "2.1.8") found components: pthreads -- Performing Test fuzz_target_builds_without_main_fuzz -- Performing Test fuzz_target_builds_without_main_fuzz - Failed -- Found BerkeleyDB component CXX: /bitcoin/depends/x86_64-linux-gnu/lib/libdb_cxx-5.3.a -- Found BerkeleyDB: /bitcoin/depends/x86_64-linux-gnu/include (found suitable version "5.3.28", minimum required is "5.3") found components: CXX -- Found SQLite3: /bitcoin/depends/x86_64-linux-gnu/include (found suitable version "3.50.4", minimum required is "3.7.17") -- Found ZeroMQ component zmq: /bitcoin/depends/x86_64-linux-gnu/lib/libzmq.a -- Found ZeroMQ: /bitcoin/depends/x86_64-linux-gnu/include (found suitable version "4.3.5", minimum required is "4.1.5") -- Could NOT find Protobuf (missing: Protobuf_DIR) -- Found Protobuf: /bitcoin/depends/x86_64-linux-gnu/lib/libprotobuf.a;-pthread (found version "3.21.12") -- Found OpenSSL: /bitcoin/depends/x86_64-linux-gnu/lib/libcrypto.a (found version "1.1.1t") -- Looking for EVP_MD_CTX_new -- Looking for EVP_MD_CTX_new - found -- Found QREncode component qrencode: /bitcoin/depends/x86_64-linux-gnu/lib/libqrencode.a -- Found QREncode: /bitcoin/depends/x86_64-linux-gnu/include CMake Warning (dev) at /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FetchContent.cmake:1267 (message): The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is not set. The policy's OLD behavior will be used. When using a URL download, the timestamps of extracted files should preferably be that of the time of extraction, otherwise code that depends on the extracted contents might not be rebuilt if the URL changes. The OLD behavior preserves the timestamps from the archive instead, but this is usually not what you want. Update your project to the NEW behavior or specify the DOWNLOAD_EXTRACT_TIMESTAMP option with a value of true to avoid this robustness issue. Call Stack (most recent call first): cmake/modules/RustHelper.cmake:4 (FetchContent_Declare) chronik/CMakeLists.txt:6 (include) This warning is for project developers. Use -Wno-dev to suppress it. [1/9] Creating directories for 'corrosion-populate' [1/9] Performing download step (download, verify and extract) for 'corrosion-populate' -- Downloading... dst='/bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/v0.5.1.tar.gz' timeout='none' inactivity timeout='none' -- Using src='https://github.com/corrosion-rs/corrosion/archive/refs/tags/v0.5.1.tar.gz' CMake Error at corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/download-corrosion-populate.cmake:127 (file): file /home/bitcoinabc/.guix-profile/etc/ssl/certs/ca-certificates.crt FAILED: corrosion-populate-prefix/src/corrosion-populate-stamp/corrosion-populate-download /bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/corrosion-populate-download cd /bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/_deps && /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/bin/cmake -P /bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/download-corrosion-populate.cmake && /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/bin/cmake -P /bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/verify-corrosion-populate.cmake && /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/bin/cmake -P /bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/extract-corrosion-populate.cmake && /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/bin/cmake -E touch /bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/corrosion-populate-download ninja: build stopped: subcommand failed. CMake Error at /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FetchContent.cmake:1604 (message): Build step for corrosion failed: 1 Call Stack (most recent call first): /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FetchContent.cmake:1744:EVAL:2 (__FetchContent_directPopulate) /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FetchContent.cmake:1744 (cmake_language) /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FetchContent.cmake:1958 (FetchContent_Populate) cmake/modules/RustHelper.cmake:9 (FetchContent_MakeAvailable) chronik/CMakeLists.txt:6 (include) -- Configuring incomplete, errors occurred! See also "/bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/CMakeFiles/CMakeOutput.log". See also "/bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/CMakeFiles/CMakeError.log". Build guix-linux failed with exit code 1 Comment Actions Build Bitcoin ABC Diffs / Diff Testing (guix-linux) failed.
Tail of the build log: -- Found Event component pthreads: /bitcoin/depends/x86_64-linux-gnu/lib/libevent_pthreads.a -- Found Event: /bitcoin/depends/x86_64-linux-gnu/include (found suitable version "99.99.99", minimum required is "2.1.8") found components: pthreads -- Performing Test fuzz_target_builds_without_main_fuzz -- Performing Test fuzz_target_builds_without_main_fuzz - Failed -- Found BerkeleyDB component CXX: /bitcoin/depends/x86_64-linux-gnu/lib/libdb_cxx-5.3.a -- Found BerkeleyDB: /bitcoin/depends/x86_64-linux-gnu/include (found suitable version "5.3.28", minimum required is "5.3") found components: CXX -- Found SQLite3: /bitcoin/depends/x86_64-linux-gnu/include (found suitable version "3.50.4", minimum required is "3.7.17") -- Found ZeroMQ component zmq: /bitcoin/depends/x86_64-linux-gnu/lib/libzmq.a -- Found ZeroMQ: /bitcoin/depends/x86_64-linux-gnu/include (found suitable version "4.3.5", minimum required is "4.1.5") -- Could NOT find Protobuf (missing: Protobuf_DIR) -- Found Protobuf: /bitcoin/depends/x86_64-linux-gnu/lib/libprotobuf.a;-pthread (found version "3.21.12") -- Found OpenSSL: /bitcoin/depends/x86_64-linux-gnu/lib/libcrypto.a (found version "1.1.1t") -- Looking for EVP_MD_CTX_new -- Looking for EVP_MD_CTX_new - found -- Found QREncode component qrencode: /bitcoin/depends/x86_64-linux-gnu/lib/libqrencode.a -- Found QREncode: /bitcoin/depends/x86_64-linux-gnu/include CMake Warning (dev) at /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FetchContent.cmake:1267 (message): The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is not set. The policy's OLD behavior will be used. When using a URL download, the timestamps of extracted files should preferably be that of the time of extraction, otherwise code that depends on the extracted contents might not be rebuilt if the URL changes. The OLD behavior preserves the timestamps from the archive instead, but this is usually not what you want. Update your project to the NEW behavior or specify the DOWNLOAD_EXTRACT_TIMESTAMP option with a value of true to avoid this robustness issue. Call Stack (most recent call first): cmake/modules/RustHelper.cmake:4 (FetchContent_Declare) chronik/CMakeLists.txt:6 (include) This warning is for project developers. Use -Wno-dev to suppress it. [1/9] Creating directories for 'corrosion-populate' [1/9] Performing download step (download, verify and extract) for 'corrosion-populate' -- Downloading... dst='/bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/v0.5.1.tar.gz' timeout='none' inactivity timeout='none' -- Using src='https://github.com/corrosion-rs/corrosion/archive/refs/tags/v0.5.1.tar.gz' CMake Error at corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/download-corrosion-populate.cmake:127 (file): file /home/bitcoinabc/.guix-profile/etc/ssl/certs/ca-certificates.crt FAILED: corrosion-populate-prefix/src/corrosion-populate-stamp/corrosion-populate-download /bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/corrosion-populate-download cd /bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/_deps && /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/bin/cmake -P /bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/download-corrosion-populate.cmake && /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/bin/cmake -P /bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/verify-corrosion-populate.cmake && /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/bin/cmake -P /bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/extract-corrosion-populate.cmake && /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/bin/cmake -E touch /bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/corrosion-populate-download ninja: build stopped: subcommand failed. CMake Error at /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FetchContent.cmake:1604 (message): Build step for corrosion failed: 1 Call Stack (most recent call first): /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FetchContent.cmake:1744:EVAL:2 (__FetchContent_directPopulate) /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FetchContent.cmake:1744 (cmake_language) /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FetchContent.cmake:1958 (FetchContent_Populate) cmake/modules/RustHelper.cmake:9 (FetchContent_MakeAvailable) chronik/CMakeLists.txt:6 (include) -- Configuring incomplete, errors occurred! See also "/bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/CMakeFiles/CMakeOutput.log". See also "/bitcoin/distsrc-b242067c1f10-x86_64-linux-gnu/CMakeFiles/CMakeError.log". Build guix-linux failed with exit code 1 Comment Actions test the quick and dirty fix for guix to allow cmake to download stuff at build time The better fix would be to get corrosion in manifest.scm and then tell cmake where to find it, but that's unrelated to this fix and can be done in a separate diff Comment Actions Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed. Diff : committed changes only (\(\ ──────────────────────────────────────── 2 files reviewed:
──────────────────────────────────────── Comment Actions Build Bitcoin ABC Diffs / Diff Testing (guix-linux) failed.
Tail of the build log: -- Found Event component pthreads: /bitcoin/depends/x86_64-linux-gnu/lib/libevent_pthreads.a -- Found Event: /bitcoin/depends/x86_64-linux-gnu/include (found suitable version "99.99.99", minimum required is "2.1.8") found components: pthreads -- Performing Test fuzz_target_builds_without_main_fuzz -- Performing Test fuzz_target_builds_without_main_fuzz - Failed -- Found BerkeleyDB component CXX: /bitcoin/depends/x86_64-linux-gnu/lib/libdb_cxx-5.3.a -- Found BerkeleyDB: /bitcoin/depends/x86_64-linux-gnu/include (found suitable version "5.3.28", minimum required is "5.3") found components: CXX -- Found SQLite3: /bitcoin/depends/x86_64-linux-gnu/include (found suitable version "3.50.4", minimum required is "3.7.17") -- Found ZeroMQ component zmq: /bitcoin/depends/x86_64-linux-gnu/lib/libzmq.a -- Found ZeroMQ: /bitcoin/depends/x86_64-linux-gnu/include (found suitable version "4.3.5", minimum required is "4.1.5") -- Could NOT find Protobuf (missing: Protobuf_DIR) -- Found Protobuf: /bitcoin/depends/x86_64-linux-gnu/lib/libprotobuf.a;-pthread (found version "3.21.12") -- Found OpenSSL: /bitcoin/depends/x86_64-linux-gnu/lib/libcrypto.a (found version "1.1.1t") -- Looking for EVP_MD_CTX_new -- Looking for EVP_MD_CTX_new - found -- Found QREncode component qrencode: /bitcoin/depends/x86_64-linux-gnu/lib/libqrencode.a -- Found QREncode: /bitcoin/depends/x86_64-linux-gnu/include CMake Warning (dev) at /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FetchContent.cmake:1267 (message): The DOWNLOAD_EXTRACT_TIMESTAMP option was not given and policy CMP0135 is not set. The policy's OLD behavior will be used. When using a URL download, the timestamps of extracted files should preferably be that of the time of extraction, otherwise code that depends on the extracted contents might not be rebuilt if the URL changes. The OLD behavior preserves the timestamps from the archive instead, but this is usually not what you want. Update your project to the NEW behavior or specify the DOWNLOAD_EXTRACT_TIMESTAMP option with a value of true to avoid this robustness issue. Call Stack (most recent call first): cmake/modules/RustHelper.cmake:4 (FetchContent_Declare) chronik/CMakeLists.txt:6 (include) This warning is for project developers. Use -Wno-dev to suppress it. [1/9] Creating directories for 'corrosion-populate' [1/9] Performing download step (download, verify and extract) for 'corrosion-populate' -- Downloading... dst='/bitcoin/distsrc-73f48143ca18-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/v0.5.1.tar.gz' timeout='none' inactivity timeout='none' -- Using src='https://github.com/corrosion-rs/corrosion/archive/refs/tags/v0.5.1.tar.gz' CMake Error at corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/download-corrosion-populate.cmake:127 (file): file /etc/ssl/certs/ca-certificates.crt FAILED: corrosion-populate-prefix/src/corrosion-populate-stamp/corrosion-populate-download /bitcoin/distsrc-73f48143ca18-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/corrosion-populate-download cd /bitcoin/distsrc-73f48143ca18-x86_64-linux-gnu/_deps && /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/bin/cmake -P /bitcoin/distsrc-73f48143ca18-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/download-corrosion-populate.cmake && /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/bin/cmake -P /bitcoin/distsrc-73f48143ca18-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/verify-corrosion-populate.cmake && /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/bin/cmake -P /bitcoin/distsrc-73f48143ca18-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/extract-corrosion-populate.cmake && /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/bin/cmake -E touch /bitcoin/distsrc-73f48143ca18-x86_64-linux-gnu/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/corrosion-populate-download ninja: build stopped: subcommand failed. CMake Error at /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FetchContent.cmake:1604 (message): Build step for corrosion failed: 1 Call Stack (most recent call first): /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FetchContent.cmake:1744:EVAL:2 (__FetchContent_directPopulate) /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FetchContent.cmake:1744 (cmake_language) /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/share/cmake-3.24/Modules/FetchContent.cmake:1958 (FetchContent_Populate) cmake/modules/RustHelper.cmake:9 (FetchContent_MakeAvailable) chronik/CMakeLists.txt:6 (include) -- Configuring incomplete, errors occurred! See also "/bitcoin/distsrc-73f48143ca18-x86_64-linux-gnu/CMakeFiles/CMakeOutput.log". See also "/bitcoin/distsrc-73f48143ca18-x86_64-linux-gnu/CMakeFiles/CMakeError.log". Build guix-linux failed with exit code 1 Comment Actions use the corrosion package for guix (require a time-machine bump to https://codeberg.org/guix/guix/commit/9e02124778ad465ac0c9c23e01da0ce5a152bd2e) Comment Actions @bot guix-linux
Comment Actions Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed. Diff : committed changes only (\(\ ──────────────────────────────────────────────────────────────────────── critical [Functional Correctness] → ]8;;vscode://file//work/contrib/guix/manifest.scm:538contrib/guix/manifest.scm:538]8;; Use the imported corrosion package object. packages->manifest accepts package objects or package/output tuples. corrosion@0.5.1 is an unquoted identifier, while the manifest imports corrosion. Manifest evaluation can therefore fail with an unbound-variable error. Suggested change - corrosion@0.5.1 + corrosion ──────────────────────────────────────── Critical 1 4 files reviewed:
──────────────────────────────────────── Print all AI prompts: coderabbit review --show-prompts Comment Actions Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.
Failed tests logs: ====== Bitcoin ABC functional tests: wallet_multiwallet.py --usecli ======
------- Stdout: -------
2026-09-03T13:35:29.212000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20260903_133354_5621/wallet_multiwallet_38
2026-09-03T13:35:42.569000Z TestFramework (INFO): Check for per-wallet settxfee call
2026-09-03T13:35:42.735000Z TestFramework (INFO): Test dynamic wallet loading
2026-09-03T13:35:43.745000Z TestFramework (INFO): Load first wallet
2026-09-03T13:35:43.862000Z TestFramework (INFO): Load second wallet
2026-09-03T13:35:43.978000Z TestFramework (INFO): Concurrent wallet loading
2026-09-03T13:35:46.176000Z TestFramework (INFO): Load remaining wallets
2026-09-03T13:35:46.228000Z TestFramework (ERROR): Called Process failed with stdout='error: Could not connect to the server 127.0.0.1:25432
Make sure the bitcoind server is running and that you are connecting to the correct RPC port.
'; stderr='None';
Traceback (most recent call last):
File "/work/test/functional/test_framework/test_framework.py", line 155, in main
self._run_test_internal()
File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
self.run_test()
File "/work/test/functional/wallet_multiwallet.py", line 425, in run_test
loadwallet_name = self.nodes[0].loadwallet(wallet_name)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/work/test/functional/test_framework/test_node.py", line 1080, in __call__
return self.cli.send_cli(self.command, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/work/test/functional/test_framework/test_node.py", line 1157, in send_cli
raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command '/work/abc-ci-builds/build-debug/src/bitcoin-cli' returned non-zero exit status 1.
2026-09-03T13:35:46.282000Z TestFramework (INFO): Not stopping nodes as test failed. The dangling processes will be cleaned up later.
2026-09-03T13:35:46.282000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20260903_133354_5621/wallet_multiwallet_38
2026-09-03T13:35:46.283000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20260903_133354_5621/wallet_multiwallet_38/test_framework.log
2026-09-03T13:35:46.283000Z TestFramework (ERROR):
2026-09-03T13:35:46.283000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20260903_133354_5621/wallet_multiwallet_38' to consolidate all logs
2026-09-03T13:35:46.283000Z TestFramework (ERROR):
2026-09-03T13:35:46.283000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2026-09-03T13:35:46.283000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2026-09-03T13:35:46.283000Z TestFramework (ERROR):
------- Stderr: -------
Exception in thread Thread-2 (test_load_unload):
Traceback (most recent call last):
File "/usr/lib/python3.11/threading.py", line 1038, in _bootstrap_inner
Exception in thread Thread-1 (test_load_unload):
Traceback (most recent call last):
File "/usr/lib/python3.11/threading.py", line 1038, in _bootstrap_inner
self.run()
File "/usr/lib/python3.11/threading.py", line 975, in run
self._target(*self._args, **self._kwargs)
File "/work/test/functional/wallet_multiwallet.py", line 36, in test_load_unload
node.loadwallet(name)
File "/work/test/functional/test_framework/test_node.py", line 1080, in __call__
return self.cli.send_cli(self.command, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/work/test/functional/test_framework/test_node.py", line 1157, in send_cli
raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command '/work/abc-ci-builds/build-debug/src/bitcoin-cli' returned non-zero exit status 1.
self.run()
File "/usr/lib/python3.11/threading.py", line 975, in run
self._target(*self._args, **self._kwargs)
File "/work/test/functional/wallet_multiwallet.py", line 37, in test_load_unload
node.unloadwallet(name)
File "/work/test/functional/test_framework/test_node.py", line 1080, in __call__
return self.cli.send_cli(self.command, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/work/test/functional/test_framework/test_node.py", line 1157, in send_cli
raise subprocess.CalledProcessError(
subprocess.CalledProcessError: Command '/work/abc-ci-builds/build-debug/src/bitcoin-cli' returned non-zero exit status 1.
[node 0] Cleaning up leftover processEach failure log is accessible here: Comment Actions Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed. Diff : committed changes only (\(\ ──────────────────────────────────────────────────────────────────────── major [Data Integrity & Integration] → ]8;;vscode://file//work/cmake/modules/RustHelper.cmake:5cmake/modules/RustHelper.cmake:5]8;; Fix the Corrosion version check. Corrosion v0.5.1 declares PROJECT_VERSION as 0.5.0 and generates its version file with SameMinorVersion. Therefore, `find_package(Corrosion 0.5.1)` rejects an unpatched installation and can trigger the network fallback. Require 0.5.0, or patch the package metadata before requiring 0.5.1. ──────────────────────────────────────────────────────────────────────── minor [Data Integrity & Integration] → ]8;;vscode://file//work/contrib/guix/manifest.scm:538contrib/guix/manifest.scm:538]8;; Add the Rust toolchain to the manifest. corrosion declares rust and (rust "cargo") as native inputs. A manifest entry does not include native inputs by default, so add rust explicitly or use package->development-manifest corrosion. ──────────────────────────────────────── Major 1 4 files reviewed:
──────────────────────────────────────── Print all AI prompts: coderabbit review --show-prompts Comment Actions Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed. Diff : committed changes only (\(\ ──────────────────────────────────────────────────────────────────────── major [Data Integrity & Integration] → ]8;;vscode://file//work/contrib/guix/manifest.scm:538contrib/guix/manifest.scm:538]8;; Add the Rust toolchain to the Guix environment. The Guix corrosion package declares rust and (rust "cargo") as native-inputs, not propagated inputs. A normal guix shell --pure -m environment therefore can include corrosion without rustc or cargo, which RustHelper.cmake requires through Rust::Rustc. Add rust and (rust "cargo") explicitly. ──────────────────────────────────────── Major 1 3 files reviewed:
──────────────────────────────────────── Print all AI prompts: coderabbit review --show-prompts Comment Actions Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed. Diff : committed changes only (\(\ ──────────────────────────────────────────────────────────────────────── major [Functional Correctness] → ]8;;vscode://file//work/cmake/modules/RustHelper.cmake:5cmake/modules/RustHelper.cmake:5]8;; Require an exact Corrosion version. find_package(Corrosion 0.5.1 QUIET) accepts newer compatible versions, while the fallback uses v0.5.1. Corrosion documents breaking changes between pre-1.0 minor releases. Use EXACT, or define and test a supported version range. ──────────────────────────────────────────────────────────────────────── major [Functional Correctness]
→ ]8;;vscode://file//work/cmake/modules/RustHelper.cmake:12cmake/modules/RustHelper.cmake:12-18]8;;
Apply the CARGO_BUILD_TARGET patch to the fallback.
Guix patches Corrosion v0.5.1 so cmake/FindRust.cmake uses
ENV{CARGO_BUILD_TARGET}. This fallback fetches unpatched upstream
v0.5.1, so cross-compilation can fall back to the host target. Apply the
same patch or use the patched Corrosion package.──────────────────────────────────────── Major 2 3 files reviewed:
──────────────────────────────────────── Print all AI prompts: coderabbit review --show-prompts Comment Actions Build Bitcoin ABC Diffs / Diff Testing (guix-linux) failed.
Tail of the build log: building /gnu/store/7pibyb82jcnp4yk0hfpgfcyimd0ixbp1-rust-cbindgen-0.26.0.drv... building /gnu/store/94mwvq8lsm3qz0vrghlqif1nkw2p1chz-python-cryptography-43.0.3.drv... --- Line discarded due to StreamReader overflow ------ Line discarded due to StreamReader overflow --- [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏building /gnu/store/dr8fipaxwfvdqn3apwhm4zgph0hyb92c-python-orjson-3.9.7.drv... note: keeping build directory `/tmp/guix-build-python-orjson-3.9.7.drv-0' builder for `/gnu/store/dr8fipaxwfvdqn3apwhm4zgph0hyb92c-python-orjson-3.9.7.drv' failed with exit code 1 build of /gnu/store/dr8fipaxwfvdqn3apwhm4zgph0hyb92c-python-orjson-3.9.7.drv failed View build log at '/var/log/guix/drvs/dr/8fipaxwfvdqn3apwhm4zgph0hyb92c-python-orjson-3.9.7.drv.gz'. building /gnu/store/vf8k46ipxf42z3121mgjc10x7mbx9nld-python-pydantic-core-2.14.6.drv... cannot build derivation `/gnu/store/lix72qcb9avhipwkp2gm105zzfwiszvp-python-scikit-build-core-0.9.3.drv': 1 dependencies couldn't be built killing process 2457563 note: keeping build directory `/tmp/guix-build-python-pydantic-core-2.14.6.drv-0' cannot build derivation `/gnu/store/kbsdqilrcgk41bqg4f5fc42gv2ima6z4-python-lief-0.16.6.drv': 1 dependencies couldn't be built guix shell: error: build of `/gnu/store/kbsdqilrcgk41bqg4f5fc42gv2ima6z4-python-lief-0.16.6.drv' failed Build guix-linux failed with exit code 1 Comment Actions Build Bitcoin ABC Diffs / Diff Testing (guix-osx) failed.
Tail of the build log: building /gnu/store/7pibyb82jcnp4yk0hfpgfcyimd0ixbp1-rust-cbindgen-0.26.0.drv... building /gnu/store/94mwvq8lsm3qz0vrghlqif1nkw2p1chz-python-cryptography-43.0.3.drv... --- Line discarded due to StreamReader overflow ------ Line discarded due to StreamReader overflow --- [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏building /gnu/store/dr8fipaxwfvdqn3apwhm4zgph0hyb92c-python-orjson-3.9.7.drv... note: keeping build directory `/tmp/guix-build-python-orjson-3.9.7.drv-0' builder for `/gnu/store/dr8fipaxwfvdqn3apwhm4zgph0hyb92c-python-orjson-3.9.7.drv' failed with exit code 1 build of /gnu/store/dr8fipaxwfvdqn3apwhm4zgph0hyb92c-python-orjson-3.9.7.drv failed View build log at '/var/log/guix/drvs/dr/8fipaxwfvdqn3apwhm4zgph0hyb92c-python-orjson-3.9.7.drv.gz'. building /gnu/store/vf8k46ipxf42z3121mgjc10x7mbx9nld-python-pydantic-core-2.14.6.drv... cannot build derivation `/gnu/store/lix72qcb9avhipwkp2gm105zzfwiszvp-python-scikit-build-core-0.9.3.drv': 1 dependencies couldn't be built killing process 2320046 note: keeping build directory `/tmp/guix-build-python-pydantic-core-2.14.6.drv-0' cannot build derivation `/gnu/store/kbsdqilrcgk41bqg4f5fc42gv2ima6z4-python-lief-0.16.6.drv': 1 dependencies couldn't be built guix shell: error: build of `/gnu/store/kbsdqilrcgk41bqg4f5fc42gv2ima6z4-python-lief-0.16.6.drv' failed Build guix-osx failed with exit code 1 Comment Actions Build Bitcoin ABC Diffs / Diff Testing (guix-win) failed.
Tail of the build log: /gnu/store/rp6nnd0aldfs5ys5kwlmlwspmzwmkfdk-gcc-cross-x86_64-w64-mingw32-14.2.0/include/c++/bits/fstream.tcc:172:16: note: mismatched types ‘std::basic_filebuf<_CharT, _Traits>’ and ‘bool’
172 | std::swap(_M_pback_init, __rhs._M_pback_init);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from Source/strlist.h:24,
from Source/lang.h:22,
from Source/icon.cpp:21:
/gnu/store/rp6nnd0aldfs5ys5kwlmlwspmzwmkfdk-gcc-cross-x86_64-w64-mingw32-14.2.0/include/c++/fstream:1338:5: note: candidat@ build-log 2631455 4061
e: ‘template<class _CharT, class _Traits> void std::swap(std::basic_ifstream<_CharT, _Traits>&, std::basic_ifstream<_CharT, _Traits>&)’
1338 | swap(basic_ifstream<_CharT, _Traits>& __x,
| ^~~~
/gnu/store/rp6nnd0aldfs5ys5kwlmlwspmzwmkfdk-gcc-cross-x86_64-w64-mingw32-14.2.0/include/c++/fstream:1338:5: note: template argument deduction/substitution failed:
In file included from /gnu/store/rp6nnd0aldfs5ys5kwlmlwspmzwmkfdk-gcc-cross-x86_64-w64-mingw32-14.2.0/include/c++/fstream:1360,
from Source/strlist.h:24,
from Source/lang.h:22,
from Source/icon.cpp:21:
/gnu/store/rp6nnd0aldfs5ys5kwlmlwspmzwmkfdk-gcc-cross-x86_64-w64-mingw32-14.2.0/include/c++/bits/fstream.tcc:172:16: note: mismatched types ‘std::basic_ifstream<_CharT, _Traits>’ and ‘bool’
172 | std::swap(_M_pback_init, __rhs._M_pback_init);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from Source/strlist.h:24,
from Source/lang.h:22,
from Source/icon.cpp:21:
/gnu/store/rp6nnd0aldfs5ys5kwlmlwspmzwmkfdk-gcc-cross-x86_64-w64-mingw32-14.2.0/include/c++/fstream:1345:5: note: candidate: ‘template<class _CharT, class _Traits> void std::swap(std::basic_ofstream<_CharT, _Traits>&, std::basic_ofstream<_CharT, _Traits>&)’
1345 | swap(basic_ofstream<_CharT, _Traits>& __x,
| ^~~~
/gnu/store/rp6nnd0aldfs5ys5kwlmlwspmzwmkfdk-gcc-cross-x86_64-w64-mingw32-14.2.0/include/c++/fstream:1345:5: note: template argument deduction/substitution failed:
In file included from /gnu/store/rp6nnd0aldfs5ys5kwlmlwspmzwmkfdk-gcc-cross-x86_64-w64-mingw32-14.2.0/include/c++/fstream:1360,
from Source/strlist.h:24,
from Source/lang.h:22,
from Source/icon.cpp:21:
/gnu/store/rp6nnd0aldfs5ys5kwlmlwspmzwmkfdk-gcc-cross-x86_64-w64-mingw32-14.2.0/include/c++/bits/fstream.tcc:172:16: note: mismatched types ‘std::basic_ofstream<_CharT, _Traits>’ and ‘bool’
172 | std::swap(_M_pback_init, __rhs._M_pback_init);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from Source/strlist.h:24,
from Source/lang.h:22,
from Source/icon.cpp:21:
/gnu/store/rp6nnd0aldfs5ys5kwlmlwspmzwmkfdk-gcc-cross-x86_64-w64-mingw32-14.2.0/include/c++/fstream:1352:5: note: candidate: ‘template<class _CharT, class _Traits> void std::swap(std::basic_fstream<_CharT, _Traits>&, std::basic_fstream<_CharT, _Traits>&)’
1352 | swap(basic_fstream<_CharT, _Traits>& __x,
| ^~~~
/gnu/store/rp6nnd0aldfs5ys5kwlmlwspmzwmkfdk-gcc-cross-x86_64-w64-mingw32-14.2.0/include/c++/fstream:1352:5: note: template argument deduction/substitution failed:
In file included from /gnu/store/rp6nnd0aldfs5ys5kwlmlwspmzwmkfdk-gcc-cross-x86_64-w64-mingw32-14.2.0/include/c++/fstream:1360,
from Source/strlist.h:24,
from Source/lang.h:22,
from Source/icon.cpp:21:
/gnu/store/rp6nnd0aldfs5ys5kwlmlwspmzwmkfdk-gcc-cross-x86_64-w64-mingw32-14.2.0/include/c++/bits/fstream.tcc:172:16: note: mismatched types ‘std::basic_fstream<_CharT, _Traits>’ and ‘bool’
172 | std::swap(_M_pback_init, __rhs._M_pback_init);
| ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /gnu/store/rp6nnd0aldfs5ys5kwlmlwspmzwmkfdk-gcc-cross-x86_64-w64-mingw32-14.2.0/include/c++/exception:166,
from /gnu/store/rp6nnd0aldfs5ys5kwlmlwspmzwmkfdk-gcc-cross-x86_64-w64-mingw32-14.2.0/include/c++/stdexcept:38,
from Source/ResourceEditor.h:97,
from Source/icon.h:22,
from Source/icon.cpp:19:
/gnu/store/rp6nnd0aldfs5ys5kwlmlwspmzwmkfdk-gcc-cross-x86_64-w64-mingw32-14.2.0/include/c++/bits/exception_ptr.h:230:5: note: candidate: ‘void std::__exception_ptr::swap(std::__exception_ptr::exception_ptr&, std::__exception_ptr::exception_ptr&)’
230 | swap(exception_ptr& __lhs, exception_ptr& __rhs)
| ^~~~
note: keeping build directory `/tmp/guix-build-nsis-x86_64-3.10.drv-0'
builder for `/gnu/store/3nq4a29yh653v2fd64s2bdvqgvcd6xla-nsis-x86_64-3.10.drv' failed with exit code 1
build of /gnu/store/3nq4a29yh653v2fd64s2bdvqgvcd6xla-nsis-x86_64-3.10.drv failed
View build log at '/var/log/guix/drvs/3n/q4a29yh653v2fd64s2bdvqgvcd6xla-nsis-x86_64-3.10.drv.gz'.
guix shell: error: build of `/gnu/store/3nq4a29yh653v2fd64s2bdvqgvcd6xla-nsis-x86_64-3.10.drv' failed
Build guix-win failed with exit code 1Comment Actions Build Bitcoin ABC Diffs / Diff Testing (guix-linux) failed.
Tail of the build log: [K100% ▕█████████████████████████████████████████████████████████████████████████▏ [K100% ▕█████████████████████████████████████████████████████████████████████████▏ [K100% ▕█████████████████████████████████████████████████████████████████████████▏ [K100% ▕█████████████████████████████████████████████████████████████████████████▏ [K100% ▕█████████████████████████████████████████████████████████████████████████▏building /gnu/store/0s8dpsw56lrds538ylsvsw721n3ayd85-maturin-1.8.0.tar.zst.drv... building /gnu/store/ygy5f247khdswfzah49m55gjnp7lgj54-rust-bindgen-cli-0.71.1.drv... building /gnu/store/6hi8ag0rc5j6xf0xj5js38gdysah5wz3-maturin-1.8.0.drv... building /gnu/store/7pibyb82jcnp4yk0hfpgfcyimd0ixbp1-rust-cbindgen-0.26.0.drv... building /gnu/store/94mwvq8lsm3qz0vrghlqif1nkw2p1chz-python-cryptography-43.0.3.drv... --- Line discarded due to StreamReader overflow ------ Line discarded due to StreamReader overflow --- [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏ [K100% 'check' ▕█████████████████████████████████████████████████████████████████▏building /gnu/store/dr8fipaxwfvdqn3apwhm4zgph0hyb92c-python-orjson-3.9.7.drv... note: keeping build directory `/tmp/guix-build-python-orjson-3.9.7.drv-0' builder for `/gnu/store/dr8fipaxwfvdqn3apwhm4zgph0hyb92c-python-orjson-3.9.7.drv' failed with exit code 1 build of /gnu/store/dr8fipaxwfvdqn3apwhm4zgph0hyb92c-python-orjson-3.9.7.drv failed View build log at '/var/log/guix/drvs/dr/8fipaxwfvdqn3apwhm4zgph0hyb92c-python-orjson-3.9.7.drv.gz'. building /gnu/store/vf8k46ipxf42z3121mgjc10x7mbx9nld-python-pydantic-core-2.14.6.drv... cannot build derivation `/gnu/store/lix72qcb9avhipwkp2gm105zzfwiszvp-python-scikit-build-core-0.9.3.drv': 1 dependencies couldn't be built killing process 1065520 note: keeping build directory `/tmp/guix-build-python-pydantic-core-2.14.6.drv-0' cannot build derivation `/gnu/store/kbsdqilrcgk41bqg4f5fc42gv2ima6z4-python-lief-0.16.6.drv': 1 dependencies couldn't be built guix shell: error: build of `/gnu/store/kbsdqilrcgk41bqg4f5fc42gv2ima6z4-python-lief-0.16.6.drv' failed Build guix-linux failed with exit code 1 Comment Actions rebase on D20567, this gives us a recent enough guix env to have corrosion and the needed changes to keep lief working Comment Actions Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed. Diff : committed changes only (\(\ ──────────────────────────────────────────────────────────────────────── major [Stability & Availability] → ]8;;vscode://file//work/contrib/guix/manifest.scm:442contrib/guix/manifest.scm:442]8;; Include the Rust toolchain in the manifest. Corrosion’s FindRust.cmake searches PATH for rustc and cargo, runs both tools, and provides Rust_VERSION and Cargo target variables. Corrosion does not provide the toolchain. A pure shell based only on this manifest can therefore fail during configuration before the Rust version check. Add the required Rust package/output, then verify: guix shell --pure --manifest=contrib/guix/manifest.scm -- \ sh -c 'rustc --version && cargo --version' ──────────────────────────────────────────────────────────────────────── major [Data Integrity & Integration] → ]8;;vscode://file//work/cmake/modules/RustHelper.cmake:5cmake/modules/RustHelper.cmake:5]8;; Align the Corrosion version requirement with the package metadata. The Guix package is version 0.5.1, but Corrosion v0.5.1 declares PROJECT_VERSION as 0.5.0 and generates CorrosionConfigVersion.cmake from that value. Therefore, find_package(Corrosion 0.5.1 QUIET) can fail and enter the GitHub-fetch fallback, which breaks offline Guix builds. Require 0.5.0, patch the package metadata to report 0.5.1, or remove the network-dependent fallback. ──────────────────────────────────────── Major 2 2 files reviewed:
──────────────────────────────────────── Print all AI prompts: coderabbit review --show-prompts | ||||||||||||||||||||||||||