Differential D20555

guix: swap moreutils for just sponge
ClosedPublic
Actions

Authored by PiRK on Sep 3 2026, 15:53.

Project Tags

None

Referenced Files

None

Subscribers

Fabien

Tokens

"Haypence" token, awarded by teamcity.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC4ae6f1ba1012: guix: swap moreutils for just sponge

Summary

We build the only moreutils utility we actually need (sponge), have less
unused stuff in the Guix environment, and, the dependency graph is
simplified. i.e we no-longer have a dependency on perl, docbook etc, for
this package.

This is a backport of core#30653 and core#31323
Depends on D20554

Test Plan

guix builds

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 3 2026, 15:53

PiRK held this revision as a draft.

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 3 2026, 15:53

teamcity edited the summary of this revision. (Show Details)Sep 3 2026, 15:53

PiRK added a child revision: D20556: guix: disable gcov in base-linux-gcc.Sep 3 2026, 15:54

Harbormaster completed remote builds in B38031: Diff 61142.Sep 3 2026, 15:55

Build Bitcoin ABC Diffs / Diff Testing (ai-review) failed.

Tail of the build log:

/work /work/abc-ci-builds/ai-review
Connecting to CodeRabbit... 0s elapsed
Preparing review... 1s elapsed

  ✗ Review limit reached

  Limit details: You’ve used all 5 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Check out review usage here.
  You can wait 10 minutes for the limit to reset.
  https://app.coderabbit.ai/settings/billing?tab=usage&orgId=79839cd4-7849-4bd5-8d6d-5ecaf453356e
  https://app.coderabbit.ai/dashboard/review-capacity?orgId=79839cd4-7849-4bd5-8d6d-5ecaf453356e

Build ai-review failed with exit code 1

@bot guix-linux guix-win guix-osx

teamcity awarded a token.Sep 3 2026, 16:00

Build Bitcoin ABC Diffs / Diff Testing (guix-osx) failed.

Tail of the build log:

-- Performing Test have_C__Wreserved_identifier - Success
-- Performing Test USE_ASM_X86_64
-- Performing Test USE_ASM_X86_64 - Success
-- Performing Test have_linker__Wl___no_undefined
-- Performing Test have_linker__Wl___no_undefined - Failed
-- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) 
-- Found Event component event: /bitcoin/depends/x86_64-apple-darwin/lib/libevent.a
-- Found Event: /bitcoin/depends/x86_64-apple-darwin/include (found suitable version "99.99.99", minimum required is "2.1.8") found components: event 
-- Found Boost component headers: /bitcoin/depends/x86_64-apple-darwin/include (found suitable version "1.81.0", minimum required is "1.64")
-- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) 
-- Found Event component pthreads: /bitcoin/depends/x86_64-apple-darwin/lib/libevent_pthreads.a
-- Found Event: /bitcoin/depends/x86_64-apple-darwin/include (found suitable version "99.99.99", minimum required is "2.1.8") found components: pthreads 
-- Performing Test fuzz_target_builds_without_main_fuzz
-- Performing Test fuzz_target_builds_without_main_fuzz - Failed
-- Found BerkeleyDB component CXX: /bitcoin/depends/x86_64-apple-darwin/lib/libdb_cxx-5.3.a
-- Found BerkeleyDB: /bitcoin/depends/x86_64-apple-darwin/include (found suitable version "5.3.28", minimum required is "5.3") found components: CXX 
-- Found SQLite3: /bitcoin/depends/x86_64-apple-darwin/include (found suitable version "3.50.4", minimum required is "3.7.17") 
-- Found ZeroMQ component zmq: /bitcoin/depends/x86_64-apple-darwin/lib/libzmq.a
-- Found ZeroMQ: /bitcoin/depends/x86_64-apple-darwin/include (found suitable version "4.3.5", minimum required is "4.1.5")  
-- Could NOT find Protobuf (missing: Protobuf_DIR)
-- Found Protobuf: /bitcoin/depends/x86_64-apple-darwin/lib/libprotobuf.a (found version "3.21.12") 
-- Found OpenSSL: /bitcoin/depends/x86_64-apple-darwin/lib/libcrypto.a (found version "1.1.1t")  
-- Looking for EVP_MD_CTX_new
-- Looking for EVP_MD_CTX_new - found
-- Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE) 
-- Found QREncode component qrencode: /bitcoin/depends/x86_64-apple-darwin/lib/libqrencode.a
-- Found QREncode: /bitcoin/depends/x86_64-apple-darwin/include   
-- Rust Toolchain: 1.87.0-x86_64-unknown-linux-gnu
-- Determining required link libraries for target x86_64-apple-darwin
-- Required static libs for target x86_64-apple-darwin: System;c;m
-- Required link flags for target x86_64-apple-darwin: 
-- Determining required link libraries for target x86_64-unknown-linux-gnu
-- Required static libs for host target x86_64-unknown-linux-gnu: gcc_s;util;rt;pthread;m;dl;c
-- Found Rust: /home/bitcoinabc/.rustup/toolchains/1.87.0-x86_64-unknown-linux-gnu/bin/rustc (found version "1.87.0") 
-- Using Corrosion as a subdirectory
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /bitcoin/modules/avalanche-lib-wasm/Cargo.toml
workspace: /bitcoin/Cargo.toml
warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
-- Performing Test have_linker__latomic
-- Performing Test have_linker__latomic - Failed
-- Found Protobuf: /bitcoin/depends/x86_64-apple-darwin/lib/libprotobuf.a (found suitable version "3.21.12", minimum required is "3.0.0") 
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /bitcoin/modules/avalanche-lib-wasm/Cargo.toml
workspace: /bitcoin/Cargo.toml
warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
-- Cross-compiling proof-manager-cli for target x86_64-apple-darwin
-- Configuring native build in /bitcoin/distsrc-17eaa166f91c-x86_64-apple-darwin/native
-- Configuring done
-- Generating done
-- Build files have been written to: /bitcoin/distsrc-17eaa166f91c-x86_64-apple-darwin
Release version 0.33.11 matches source package filename bitcoin-abc-0.33.11
ninja: error: 'src/qt/protobuf::protoc', needed by 'src/qt/paymentrequest.pb.cc', missing and no known rule to make it
Build guix-osx failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (guix-win) failed.

Tail of the build log:

   Compiling concurrent-queue v2.5.0
   Compiling rand_chacha v0.9.0
   Compiling rand_chacha v0.3.1
   Compiling sha1 v0.11.0
   Compiling hash32 v0.2.1
   Compiling thiserror-impl v1.0.69
   Compiling spin v0.9.8
   Compiling bitcoinsuite-slp v0.1.0 (/bitcoin/chronik/bitcoinsuite-slp)
   Compiling tracing-core v0.1.34
   Compiling bimap v0.6.3
   Compiling tower-layer v0.3.3
   Compiling utf8_iter v1.0.4
   Compiling versions v6.3.2
   Compiling virtue v0.0.18
   Compiling parking v2.2.1
   Compiling idna v1.1.0
   Compiling event-listener v5.4.1
   Compiling chronik-plugin-common v0.1.0 (/bitcoin/chronik/chronik-plugin-common)
   Compiling bincode_derive v2.0.1
   Compiling tracing v0.1.41
   Compiling chronik-proto v0.1.0 (/bitcoin/chronik/chronik-proto)
   Compiling librocksdb-sys v0.17.3+10.4.2
   Compiling tungstenite v0.30.0
   Compiling rand v0.8.5
   Compiling rand v0.9.2
   Compiling chronik-bridge v0.1.0 (/bitcoin/chronik/chronik-bridge)
   Compiling cxxbridge-macro v1.0.138
   Compiling http-body-util v0.1.3
   Compiling cobs v0.3.0
   Compiling async-trait v0.1.89
   Compiling sha1 v0.10.6
   Compiling httpdate v1.0.3
   Compiling utf-8 v0.7.6
   Compiling sync_wrapper v1.0.2
   Compiling unty v0.0.4
   Compiling foldhash v0.1.5
   Compiling bincode v2.0.1
   Compiling tungstenite v0.24.0
   Compiling hyper v1.7.0
   Compiling postcard v1.1.3
error: failed to run custom build command for `chronik-proto v0.1.0 (/bitcoin/chronik/chronik-proto)`

Caused by:
  process didn't exit successfully: `/bitcoin/distsrc-17eaa166f91c-x86_64-w64-mingw32/./cargo/build/release/build/chronik-proto-3c90e34f9ed69b47/build-script-build` (exit status: 101)
  --- stderr

  thread 'main' panicked at /home/bitcoinabc/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/prost-build-0.11.9/src/lib.rs:1457:10:
  Could not find `protoc` installation and this build crate cannot proceed without
      this knowledge. If `protoc` is installed and this crate had trouble finding
      it, you can set the `PROTOC` environment variable with the specific path to your
      installed `protoc` binary.If you're on debian, try `apt-get install protobuf-compiler` or download it from https://github.com/protocolbuffers/protobuf/releases

  For more information: https://docs.rs/prost-build/#sourcing-protoc

  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
FAILED: chronik/CMakeFiles/_cargo-build_chronik_lib /bitcoin/distsrc-17eaa166f91c-x86_64-w64-mingw32/chronik/CMakeFiles/_cargo-build_chronik_lib 
cd /bitcoin/chronik/chronik-lib && /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/bin/cmake -E env CC_x86_64_pc_windows_gnu=/home/bitcoinabc/.guix-profile/bin/x86_64-w64-mingw32-gcc CXX_x86_64_pc_windows_gnu=/home/bitcoinabc/.guix-profile/bin/x86_64-w64-mingw32-g++ AR_x86_64_pc_windows_gnu=/home/bitcoinabc/.guix-profile/bin/x86_64-w64-mingw32-ar CORROSION_BUILD_DIR=/bitcoin/distsrc-17eaa166f91c-x86_64-w64-mingw32/chronik CARGO_BUILD_RUSTC=/home/bitcoinabc/.rustup/toolchains/1.87.0-x86_64-unknown-linux-gnu/bin/rustc /home/bitcoinabc/.rustup/toolchains/1.87.0-x86_64-unknown-linux-gnu/bin/cargo rustc --lib --target=x86_64-pc-windows-gnu --package chronik_lib --manifest-path /bitcoin/chronik/chronik-lib/Cargo.toml --target-dir /bitcoin/distsrc-17eaa166f91c-x86_64-w64-mingw32/./cargo/build --release --locked -- -Cdefault-linker-libraries=yes -Clink-args=--target=x86_64-w64-mingw32
ninja: build stopped: subcommand failed.
Build guix-win failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (guix-linux) failed.

Tail of the build log:

   Compiling rand v0.10.2
   Compiling rand_chacha v0.9.0
   Compiling rand_chacha v0.3.1
   Compiling sha1 v0.11.0
   Compiling thiserror-impl v1.0.69
   Compiling hash32 v0.2.1
   Compiling bitcoinsuite-slp v0.1.0 (/bitcoin/chronik/bitcoinsuite-slp)
   Compiling spin v0.9.8
   Compiling tracing-core v0.1.34
   Compiling tower-layer v0.3.3
   Compiling virtue v0.0.18
   Compiling parking v2.2.1
   Compiling versions v6.3.2
   Compiling utf8_iter v1.0.4
   Compiling bimap v0.6.3
   Compiling tracing v0.1.41
   Compiling idna v1.1.0
   Compiling bincode_derive v2.0.1
   Compiling chronik-plugin-common v0.1.0 (/bitcoin/chronik/chronik-plugin-common)
   Compiling librocksdb-sys v0.17.3+10.4.2
   Compiling event-listener v5.4.1
   Compiling chronik-proto v0.1.0 (/bitcoin/chronik/chronik-proto)
   Compiling tungstenite v0.30.0
   Compiling rand v0.8.5
   Compiling rand v0.9.2
   Compiling chronik-bridge v0.1.0 (/bitcoin/chronik/chronik-bridge)
   Compiling cxxbridge-macro v1.0.138
   Compiling http-body-util v0.1.3
   Compiling cobs v0.3.0
   Compiling async-trait v0.1.89
   Compiling sha1 v0.10.6
   Compiling foldhash v0.1.5
   Compiling utf-8 v0.7.6
   Compiling unty v0.0.4
   Compiling sync_wrapper v1.0.2
   Compiling httpdate v1.0.3
   Compiling bincode v2.0.1
   Compiling hyper v1.7.0
   Compiling tungstenite v0.24.0
   Compiling postcard v1.1.3
error: failed to run custom build command for `chronik-proto v0.1.0 (/bitcoin/chronik/chronik-proto)`

Caused by:
  process didn't exit successfully: `/bitcoin/distsrc-17eaa166f91c-x86_64-linux-gnu/./cargo/build/release/build/chronik-proto-3c90e34f9ed69b47/build-script-build` (exit status: 101)
  --- stderr

  thread 'main' panicked at /home/bitcoinabc/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/prost-build-0.11.9/src/lib.rs:1457:10:
  Could not find `protoc` installation and this build crate cannot proceed without
      this knowledge. If `protoc` is installed and this crate had trouble finding
      it, you can set the `PROTOC` environment variable with the specific path to your
      installed `protoc` binary.If you're on debian, try `apt-get install protobuf-compiler` or download it from https://github.com/protocolbuffers/protobuf/releases

  For more information: https://docs.rs/prost-build/#sourcing-protoc

  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
FAILED: chronik/CMakeFiles/_cargo-build_chronik_lib /bitcoin/distsrc-17eaa166f91c-x86_64-linux-gnu/chronik/CMakeFiles/_cargo-build_chronik_lib 
cd /bitcoin/chronik/chronik-lib && /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/bin/cmake -E env CC_x86_64_unknown_linux_gnu=/gnu/store/mnkiagym6zidkmi7cwdsq8gixsrjnvm6-gcc-cross-x86_64-linux-gnu-13.3.0/bin/x86_64-linux-gnu-gcc CXX_x86_64_unknown_linux_gnu=/gnu/store/mnkiagym6zidkmi7cwdsq8gixsrjnvm6-gcc-cross-x86_64-linux-gnu-13.3.0/bin/x86_64-linux-gnu-g++ AR_x86_64_unknown_linux_gnu=/bin/x86_64-linux-gnu-ar CORROSION_BUILD_DIR=/bitcoin/distsrc-17eaa166f91c-x86_64-linux-gnu/chronik CARGO_BUILD_RUSTC=/home/bitcoinabc/.rustup/toolchains/1.87.0-x86_64-unknown-linux-gnu/bin/rustc /home/bitcoinabc/.rustup/toolchains/1.87.0-x86_64-unknown-linux-gnu/bin/cargo rustc --lib --target=x86_64-unknown-linux-gnu --package chronik_lib --manifest-path /bitcoin/chronik/chronik-lib/Cargo.toml --target-dir /bitcoin/distsrc-17eaa166f91c-x86_64-linux-gnu/./cargo/build --release --locked -- -Cdefault-linker-libraries=yes
ninja: build stopped: subcommand failed.
Build guix-linux failed with exit code 1

rebase

Harbormaster completed remote builds in B38037: Diff 61148.Sep 3 2026, 19:37

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) I'm a lean, mean, code review machine.

────────────────────────────────────────────────────────────────────────

critical [Functional Correctness]
→ ]8;;vscode://file//work/contrib/guix/manifest.scm:515contrib/guix/manifest.scm:515-516]8;;

Fix the source URI before merging.

The string literal contains a newline and indentation between snapshot/
and moreutils-. The resulting URI does not identify the intended
archive, so url-fetch cannot reliably fetch the source and the package
build fails.


Proposed fix

               (uri (string-append
-                    "https://git.joeyh.name/index.cgi/moreutils.git/snapshot/
-                    moreutils-" version ".tar.gz"))
+                    "https://git.joeyh.name/index.cgi/moreutils.git/snapshot/"
+                    "moreutils-" version ".tar.gz"))

────────────────────────────────────────
Review complete
1 finding ✔

Critical 1

1 file reviewed:

contrib/guix/manifest.scm

────────────────────────────────────────

Print all AI prompts: coderabbit review --show-prompts

PiRK published this revision for review.Sep 3 2026, 21:07

Fabien accepted this revision.Sep 4 2026, 07:34

Fabien subscribed.

Fabien added inline comments.

contrib/guix/manifest.scm
507 ↗	(On Diff #61148)

This revision is now accepted and ready to land.Sep 4 2026, 07:34

Closed by commit rABC4ae6f1ba1012: guix: swap moreutils for just sponge. · Explain WhySep 4 2026, 08:14

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC4ae6f1ba1012: guix: swap moreutils for just sponge.

Revision Contents
Changeset List

Path

Size

contrib/

guix/

manifest.scm

35 lines

Diff 61165

View Options

guix: swap moreutils for just spongeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 61165

contrib/guix/manifest.scm

guix: swap moreutils for just sponge
ClosedPublic
Actions

Revision Contents
Changeset List