Paths

Table of Contentst

Differential D20563

guix: use GCC 14.3.0 over 13.3.0
ClosedPublic
Actions

Authored by PiRK on Sep 4 2026, 07:23.

Project Tags

None

Referenced Files

	F86007840: D20563.1791423375.diff
	Wed, Oct 7, 01:36

	F86007839: D20563.1791423373.diff
	Wed, Oct 7, 01:36

	F86007838: D20563.1791423372.diff
	Wed, Oct 7, 01:36

	F86007837: D20563.1791423355.diff
	Wed, Oct 7, 01:35

	F86007823: D20563.1791423226.diff
	Wed, Oct 7, 01:33

	F86002438: D20563.1791393835.diff
	Tue, Oct 6, 17:23

Subscribers

Fabien

Tokens

"Mountain of Wealth" token, awarded by teamcity.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa6ff76459d2e: guix: use GCC 14.3.0 over 13.3.0

Summary

guix: disable building libgomp in GCC

Prunes:
libgomp.a
libgomp.la
libgomp.so
libgomp.so.1
libgomp.so.1.0.0
libgomp.spec

guix: disable libquadmath in GCC

Prunes:
libquadmath.a
libquadmath.la
libquadmath.so
libquadmath.so.0
libquadmath.so.0.0.0

guix: build GCC with --enable-host-bind-now

guix: disable gprofng in GCC

guix: use GCC 14.3.0 over 13.3.0

This will eventually be needed for #25573, and could be useful
for #30210.

guix: Apply SSA generation patch to maintain determinism

See:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=123351
https://gcc.gnu.org/pipermail/gcc-patches/2026-January/704817.html

This is a backport of core#33575
Depends on D20562

Test Plan

guix builds

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 4 2026, 07:23

PiRK held this revision as a draft.

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2026, 07:23

teamcity edited the summary of this revision. (Show Details)Sep 4 2026, 07:23

@bot guix-linux guix-win guix-osx

teamcity awarded a token.Sep 4 2026, 07:23

@bot guix-linux

teamcity updated a token.Sep 4 2026, 07:23

Harbormaster completed remote builds in B38047: Diff 61160.Sep 4 2026, 07:26

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Veni, Vidi, Validavi. I came, I saw, I reviewed.

────────────────────────────────────────
Review complete
No findings ✔

2 files reviewed:

contrib/guix/manifest.scm
contrib/guix/patches/gcc-ssa-generation.patch

────────────────────────────────────────

PiRK added a child revision: D20564: guix: build for Linux HOSTS with -static-libgcc.Sep 4 2026, 08:03

Build Bitcoin ABC Diffs / Diff Testing (guix-win) failed.

Tail of the build log:

  CRATE_CC_NO_DEFAULTS = None
  TARGET = Some(x86_64-pc-windows-gnu)
  CARGO_CFG_TARGET_FEATURE = Some(cmpxchg16b,fxsr,sse,sse2,sse3)
  HOST = Some(x86_64-unknown-linux-gnu)
  cargo:rerun-if-env-changed=CFLAGS
  CFLAGS = None
  cargo:rerun-if-env-changed=TARGET_CFLAGS
  TARGET_CFLAGS = None
  cargo:rerun-if-env-changed=CFLAGS_x86_64_pc_windows_gnu
  CFLAGS_x86_64_pc_windows_gnu = None
  cargo:rerun-if-env-changed=CFLAGS_x86_64-pc-windows-gnu
  CFLAGS_x86_64-pc-windows-gnu = None
  cargo:warning=In file included from ../../../src/secp256k1/src/util.h:14,
  cargo:warning=                 from ../../../src/secp256k1/src/field.h:10,
  cargo:warning=                 from ../../../src/secp256k1/src/group.h:10,
  cargo:warning=                 from ../../../src/secp256k1/src/precomputed_ecmult_gen.c:3:
  cargo:warning=/gnu/store/c287gnsihv4f2smsdk34mpimdpvniixd-mingw-w64-x86_64-winpthreads-12.0.0/include/stdio.h:380:1: error: expected identifier or '(' before '{' token
  cargo:warning=  380 | {
  cargo:warning=      | ^
  cargo:warning=In file included from ../../../src/secp256k1/src/field.h:10,
  cargo:warning=                 from ../../../src/secp256k1/src/group.h:10,
  cargo:warning=                 from ../../../src/secp256k1/src/precomputed_ecmult_gen.c:3:
  cargo:warning=../../../src/secp256k1/src/util.h: In function 'checked_malloc':
  cargo:warning=../../../src/secp256k1/src/util.h:157:17: error: implicit declaration of function 'malloc' [-Wimplicit-function-declaration]
  cargo:warning=  157 |     void *ret = malloc(size);
  cargo:warning=      |                 ^~~~~~
  cargo:warning=../../../src/secp256k1/src/util.h:16:1: note: include '<stdlib.h>' or provide a declaration of 'malloc'
  cargo:warning=   15 | #include <limits.h>
  cargo:warning=  +++ |+#include <stdlib.h>
  cargo:warning=   16 | 
  cargo:warning=../../../src/secp256k1/src/util.h:157:17: warning: incompatible implicit declaration of built-in function 'malloc' [-Wbuiltin-declaration-mismatch]
  cargo:warning=  157 |     void *ret = malloc(size);
  cargo:warning=      |                 ^~~~~~
  cargo:warning=../../../src/secp256k1/src/util.h:157:17: note: include '<stdlib.h>' or provide a declaration of 'malloc'

  --- stderr


  error occurred in cc-rs: command did not execute successfully (status code exit status: 1): LC_ALL="C" "/home/bitcoinabc/.guix-profile/bin/x86_64-w64-mingw32-gcc" "-O3" "-ffunction-sections" "-fdata-sections" "-m64" "-I" "../../../src/secp256k1/" "-I" "../../../src/secp256k1/include" "-I" "../../../src/secp256k1/src" "-I" "wasm/wasm-sysroot" "-Wall" "-Wextra" "-Wno-unused-function" "-Wno-unused-parameter" "-DSECP256K1_STATIC=1" "-DSECP256K1_API=extern" "-DENABLE_MODULE_ECDH=1" "-DENABLE_MODULE_SCHNORRSIG=1" "-DENABLE_MODULE_SCHNORR=1" "-DENABLE_MODULE_EXTRAKEYS=1" "-Dprintf(...)=" "-DECMULT_GEN_PREC_BITS=4" "-DECMULT_WINDOW_SIZE=15" "-DUSE_EXTERNAL_DEFAULT_CALLBACKS=1" "-DENABLE_MODULE_RECOVERY=1" "-o" "/bitcoin/distsrc-40d10c552026-x86_64-w64-mingw32/./cargo/build/x86_64-pc-windows-gnu/release/build/ecash-secp256k1-sys-8ba2b12f2960bc33/out/77bfc82200067377-precomputed_ecmult_gen.o" "-c" "../../../src/secp256k1/src/precomputed_ecmult_gen.c"


warning: build failed, waiting for other jobs to finish...
[234/619] Building CXX object src/CMakeFiles/common.dir/common/netif.cpp.obj
FAILED: apps/proof-manager-cli/CMakeFiles/_cargo-build_proof-manager-cli /bitcoin/distsrc-40d10c552026-x86_64-w64-mingw32/apps/proof-manager-cli/CMakeFiles/_cargo-build_proof-manager-cli 
cd /bitcoin/apps/proof-manager-cli && /gnu/store/4jc02ncv94xnk6rf515m90z7b5l354pa-cmake-minimal-3.24.2/bin/cmake -E env RUSTFLAGS=-Clink-arg=-Wl,--no-insert-timestamp CARGO_TARGET_X86_64_PC_WINDOWS_GNU_LINKER=/home/bitcoinabc/.guix-profile/bin/x86_64-w64-mingw32-gcc CC_x86_64_pc_windows_gnu=/home/bitcoinabc/.guix-profile/bin/x86_64-w64-mingw32-gcc CXX_x86_64_pc_windows_gnu=/home/bitcoinabc/.guix-profile/bin/x86_64-w64-mingw32-g++ AR_x86_64_pc_windows_gnu=/home/bitcoinabc/.guix-profile/bin/x86_64-w64-mingw32-ar CORROSION_BUILD_DIR=/bitcoin/distsrc-40d10c552026-x86_64-w64-mingw32/apps/proof-manager-cli CARGO_BUILD_RUSTC=/home/bitcoinabc/.rustup/toolchains/1.87.0-x86_64-unknown-linux-gnu/bin/rustc /home/bitcoinabc/.rustup/toolchains/1.87.0-x86_64-unknown-linux-gnu/bin/cargo rustc --bin=proof-manager-cli --target=x86_64-pc-windows-gnu --package proof-manager-cli --manifest-path /bitcoin/apps/proof-manager-cli/Cargo.toml --target-dir /bitcoin/distsrc-40d10c552026-x86_64-w64-mingw32/./cargo/build --profile=release --locked -- -Cdefault-linker-libraries=yes
[236/619] Building CXX object src/CMakeFiles/common.dir/common/init.cpp.obj
[237/619] Building CXX object src/CMakeFiles/common.dir/compressor.cpp.obj
[238/619] Building CXX object src/CMakeFiles/common.dir/common/system.cpp.obj
[239/619] Building CXX object src/CMakeFiles/common.dir/common/configfile.cpp.obj
[240/619] Building CXX object src/CMakeFiles/common.dir/eventloop.cpp.obj
[241/619] Building CXX object src/CMakeFiles/common.dir/consensus/merkle.cpp.obj
[242/619] Building CXX object src/CMakeFiles/common.dir/cashaddrenc.cpp.obj
[243/619] Building CXX object src/CMakeFiles/common.dir/config.cpp.obj
[244/619] Building CXX object chronik/CMakeFiles/chronik-bridge.dir/chronik-cpp/chronik_bridge.cpp.obj
[245/619] Building CXX object src/CMakeFiles/common.dir/common/pcp.cpp.obj
[246/619] Building CXX object src/CMakeFiles/common.dir/chainparams.cpp.obj
[247/619] Building CXX object src/CMakeFiles/common.dir/common/args.cpp.obj
[248/619] Building CXX object src/CMakeFiles/common.dir/coins.cpp.obj
ninja: build stopped: subcommand failed.
Build guix-win failed with exit code 1

PiRK mentioned this in D20562: guix: disable libsanitizer in Linux GCC build.Sep 4 2026, 09:14

I don't understand this eroor. secp256k1/src/util.h already includes stdlib.h

don't unconditionnaly define printf macro, it breaks stdio.h

@bot guix-win

teamcity updated a token.Sep 4 2026, 09:43

Harbormaster completed remote builds in B38049: Diff 61170.Sep 4 2026, 09:54

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Pop quiz, hotshot. There's a bug in your code. What do you do?

────────────────────────────────────────────────────────────────────────

major [Functional Correctness]
→ ]8;;vscode://file//work/modules/ecash-secp256k1/ecash-secp256k1-sys/build.rs:39modules/ecash-secp256k1/ecash-secp256k1-sys/build.rs:39]8;;

Use CARGO_CFG_TARGET_ARCH for the WASM check.

cfg!(target_arch = "wasm32") uses the build-script host architecture. A
non-WASM host targeting wasm32 therefore skips the printf(...)
definition. A compiled secp256k1 source that calls printf can then leave
an unresolved symbol because the WASM stdio.h is empty. Use the existing
CARGO_CFG_TARGET_ARCH pattern.

────────────────────────────────────────
Review complete
1 finding ✔

Major 1

3 files reviewed: