Identify from/to tokens from settle output order instead of requiring a seller postage input. Some alp-dex settles fund miner fee from token dust only (FIRMA→XECX e02902d5...), so the fee wallet fell through to generic SEND rows including a phantom receive of the other token.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC28306f1cfbc7: [ecash-parse] Classify alp-dex fee settles without postage inputs
- cd modules/ecash-parse && npm test
- On the fee wallet, e02902d547debea9f2537c8fedfb5c7c13d74647b20af07bcfa5ad5438bbc81c shows Received alp-dex fee 0.0030 FIRMA (not SEND FIRMA + SEND XECX)
- Confirm d28f81af52188ac2c4df2a39ca51e67010047748451b65d50a80baf551e1d9e8 and e008f6206ed6d2a1087189735b9e31dba84d2293332896374ea7753022058611 still show Received alp-dex fee XECX
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) If it was easy, it'd be called printf.
────────────────────────────────────────
Review complete
No findings ✔
3 files reviewed:
- modules/ecash-parse/src/alpSwap.test.ts
- modules/ecash-parse/src/parseAlpSwap.ts
- modules/ecash-parse/src/types.ts
────────────────────────────────────────