major [Data Integrity & Integration]
→ ]8;;vscode://file//work/doc/standards/xecvibe.md:5doc/standards/xecvibe.md:5]8;;

Document the wire format before shipping the protocol.

This file ends after the Output layout heading. Define the push order,
site encoding, memo encoding and length, and handling of extra pushes. Add
invalid examples so producers and consumers implement the same contract.

major [Data Integrity & Integration]
→ ]8;;vscode://file//work/modules/ecash-parse/src/parseTx.ts:634modules/ecash-parse/src/parseTx.ts:634]8;;

Preserve legacy XecVibe transactions during parsing.

This check marks every previously valid   transaction as invalid.
On-chain transactions cannot be rewritten, and the unchanged XECV LOKAD
provides no version boundary. Accept the legacy three-push shape with site
validation and normalize it to { memo }; keep the two-push shape for
newly created transactions. Apply the same compatibility rule in
parseOpReturnRaw.

major [Data Integrity & Integration]
→ ]8;;vscode://file//work/cashtab/src/opreturn/index.ts:244cashtab/src/opreturn/index.ts:244]8;;

Preserve legacy XecVibe payloads when parsing.

This check rejects every previously valid   payload. The LOKAD is
unchanged, so existing on-chain transactions and BIP21 op_return_raw
links remain in circulation. Keep a legacy three-push read path with site
validation, normalize it to the new memo result, and use the two-push
shape for new payments. Apply the same rule in parseTx.

major [Data Integrity & Integration]
→ ]8;;vscode://file//work/modules/ecash-wallet/package.json:3modules/ecash-wallet/package.json:3]8;;

The package version moves backwards from 6.2.1 to 6.2.0.

npm rejects a publish for a version that already exists, so this blocks
release of ecash-wallet. Workspace consumers that resolve ^6.2.1 also
break. Set the version to 6.2.2 or higher.





🔧 Proposed fix

-    "version": "6.2.0",
+    "version": "6.2.2",

minor [Maintainability & Code Quality]
→ ]8;;vscode://file//work/apps/alp-fusion/src/client/oneshot.ts:11apps/alp-fusion/src/client/oneshot.ts:11]8;;

Limit this statement to the one-shot flow.

README.md and DEPLOY.md identify TCP/TLS framing as landed. State that
this in-process module does not use TCP/TLS. Do not state that TCP/TLS
lands only in follow-up diffs.

minor [Functional Correctness]
→ ]8;;vscode://file//work/apps/alp-dex/test/quotes.test.ts:228apps/alp-dex/test/quotes.test.ts:228]8;;

Keep a numeric price-impact oracle.

This assertion accepts any positive percentage. A regression that reports
1 or 99 for this fixture will pass. Assert the expected value within a
tolerance, or derive the expected value from the fixture reserves and
input amount.

major [Functional Correctness]
→ ]8;;vscode://file//work/modules/ecash-agora/src/agora.ts:1201modules/ecash-agora/src/agora.ts:1201-1205]8;;

Detect the partial-change offer instead of requiring P2PKH.

acceptTx permits any recipientScript. If a full PARTIAL accept sends
tokens to a P2SH script, output 2 does not start with 76a914. This code
then selects output 3, which is not the taker token output.
historicOffers() leaves takenInfo unset for that valid accept.

Select index 3 only when output 2 is an Agora plugin output. Add a
regression test with a full PARTIAL accept that uses Script.p2sh(...) as
recipientScript.


Proposed fix

-const takerBuyIndex = tx.outputs[2].outputScript.startsWith(
-    '76a914',
-)
-    ? 2
-    : 3;
+const takerBuyIndex =
+    typeof tx.outputs[2].plugins !== 'undefined' &&
+    PLUGIN_NAME in tx.outputs[2].plugins
+        ? 3
+        : 2;

major [Stability & Availability]
→ ]8;;vscode://file//work/contrib/guix/manifest.scm:286contrib/guix/manifest.scm:286-291]8;;

Use nss-certs for SSL_CERT_FILE. python-oscrypto does not install
etc/ssl/certs/ca-certificates.crt, so its search path can set
SSL_CERT_FILE to a nonexistent file. Propagate nss-certs and use its
certificate search path, or install the bundle at this path.

major [Stability & Availability]
→ ]8;;vscode://file//work/apps/alp-fusion/src/protocol/covert.ts:601apps/alp-fusion/src/protocol/covert.ts:601]8;;

Handle getTypes() rejection and close the connection.

If getTypes() rejects before the receive loop starts, serveCovertPeer
can reject before any cleanup runs. Callers use `void
serveCovertPeer(...), so conn` can remain open and the rejection can
become unhandled. Catch this failure, close conn, and return.


Proposed fix

-    const types = await getTypes();
+    let types: ProtoTypes;
+    try {
+        types = await getTypes();
+    } catch {
+        conn.close();
+        return;
+    }

Add a regression test that makes getTypes() reject and verifies that
serveCovertPeer resolves after it closes conn.