Differential D20574

cmake: bump the minimum required version to 3.25
ClosedPublic
Actions

Authored by PiRK on Mon, Sep 7, 10:42.

Project Tags

None

Referenced Files

	F86007716: D20574.1791422310.diff
	Wed, Oct 7, 01:18

	F86007319: D20574.1791417702.diff
	Wed, Oct 7, 00:01

	F86007318: D20574.1791417700.diff
	Wed, Oct 7, 00:01

	F86007316: D20574.1791417688.diff
	Wed, Oct 7, 00:01

	F86000038: D20574.1791385167.diff
	Tue, Oct 6, 14:59

	F85997825: D20574.1791376740.diff
	Tue, Oct 6, 12:39

Subscribers

None

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC58dda889017f: cmake: bump the minimum required version to 3.25

Summary

Most recent distros have a newer version of cmake.

The notable distros that don't ship 3.25 are:

Ubuntu 22.04 LTS (EOL 2027)
Debian 11 Bullseye (EOL since 31 August 2026)

They have options to install a newer cmake.

Get rid of a warning in RustHelper.cmake by setting DOWNLOAD_EXTRACT_TIMESTAMP (introduced in 3.24)

Depends on D20546

Test Plan

cmake .. -GNinja -DBUIL_CHRONIK=1
ninja all check-all`

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mon, Sep 7, 10:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Sep 7, 10:42

PiRK requested review of this revision.Mon, Sep 7, 10:42

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) My code reviews are like a Tesla: fully electric, increasingly autonomous, and occasionally on fire.

────────────────────────────────────────
Review complete
No findings ✔

3 files reviewed:

CMakeLists.txt
cmake/modules/RustHelper.cmake
doc/dependencies.md

────────────────────────────────────────

Harbormaster completed remote builds in B38072: Diff 61206.Mon, Sep 7, 11:13

i accidentaly created a new diff, this is the continuation of D20549

PiRK mentioned this in D20549: cmake: bump the minimum required version to 3.24.Mon, Sep 7, 11:22

Fabien accepted this revision.Mon, Sep 7, 14:29

This revision is now accepted and ready to land.Mon, Sep 7, 14:29

Closed by commit rABC58dda889017f: cmake: bump the minimum required version to 3.25. · Explain WhyTue, Sep 8, 10:18

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC58dda889017f: cmake: bump the minimum required version to 3.25.

PiRK mentioned this in D20592: build: fix crossbuild for osx.Tue, Sep 8, 12:51

PiRK mentioned this in rABC0833f652ad89: build: fix crossbuild for osx.Tue, Sep 8, 13:02

PiRK mentioned this in D20607: cmake: always use the github tar.gz for corrosion, with original timestamp.Wed, Sep 9, 17:54

PiRK mentioned this in rABC5b1606ec6610: cmake: always use the github tar.gz for corrosion, with original timestamp.Thu, Sep 10, 09:09

Revision Contents
Changeset List

Path

Size

CMakeLists.txt

2 lines

cmake/

modules/

RustHelper.cmake

1 line

doc/

dependencies.md

2 lines

Diff 61240

View Options

CMakeLists.txt

View Options

cmake/modules/RustHelper.cmake

View Options

cmake: bump the minimum required version to 3.25ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 61240

CMakeLists.txt

cmake/modules/RustHelper.cmake

doc/dependencies.md

cmake: bump the minimum required version to 3.25
ClosedPublic
Actions

Revision Contents
Changeset List