A malicious server could cause the network thread to raise an error with a malformed header. Default settings for Electrum ABC is to connect only to whitelisted servers, so the impact is limited to users disabling this setting in the Network settings menu.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABCe63aefac129d: [electrum] guard against malformed headers
run the application for a while (enough to be notified of new blocks) and check everything works as expected
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) Rabbit check: I hopped through the diff and found carrots... and landmines.
────────────────────────────────────────
Review complete
No findings ✔
1 file reviewed:
- electrum/electrumabc/network.py
────────────────────────────────────────