The use of binascii made sense before python 3.5, but now we can use the builtin bytes.hex method instead. This simplifies the code and removes the need think about "byte hex to unicode" concept (the unicode type was a python 2 concept to write code that is compatible with python 3 strings, as python 2 strings were bytes))
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABCa8077e2dab38: [electrum] drop b2hu helper function
electrum unit tests and functional tests
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) I like what you did here. I don't like *that* you did it here.
────────────────────────────────────────
Review complete
No findings ✔
16 files reviewed:
- electrum/electrumabc/bitcoin.py
- electrum/electrumabc/crypto.py
- electrum/electrumabc/keystore.py
- electrum/electrumabc/paymentrequest.py
- electrum/electrumabc/synchronizer.py
- electrum/electrumabc/tests/test_bitcoin.py
- electrum/electrumabc/tests/test_mnemonic.py
- electrum/electrumabc/tests/test_transaction.py
- electrum/electrumabc/transaction.py
- electrum/electrumabc/util.py
... and 6 more files
────────────────────────────────────────