[electrum] remove more binascii.hexlify and unhexlify instances
ClosedPublic
Actions

Authored by PiRK on Sep 8 2026, 10:06.

Project Tags

None

Referenced Files

None

Subscribers

None

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCfd4a8909a582: [electrum] remove more binascii.hexlify and unhexlify instances

Summary

binascii.unhexlify can be replaced transparently with the builtin bytes.fromhex method.

binascii.hexlify is similar to bytes.hex except that it returns a weird ascii-encoded bytes object

>>> binascii.hexlify(b"\xde\xad\xbe\xef")
b'deadbeef'
>>> binascii.hexlify(b"\xde\xad\xbe\xef").decode("ascii")
'deadbeef'
>>> b"\xde\xad\xbe\xef".hex()
'deadbeef'
>>>

Depends on D20585

Test Plan

electrum unit tests and functional tests

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sep 8 2026, 10:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 8 2026, 10:06

PiRK requested review of this revision.Sep 8 2026, 10:06

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Fight fire with fire. Review AI with AI.

────────────────────────────────────────
Review complete
No findings ✔

5 files reviewed:

electrum/electrumabc/address.py
electrum/electrumabc/pem.py
electrum/electrumabc_plugins/digitalbitbox/digitalbitbox.py
electrum/electrumabc_plugins/keepkey/keepkey.py
electrum/electrumabc_plugins/trezor/trezor.py

────────────────────────────────────────

Harbormaster completed remote builds in B38099: Diff 61236.Sep 8 2026, 10:12

PiRK added inline comments.Sep 8 2026, 10:13

electrum/electrumabc/pem.py
38 ↗	(On Diff #61236)	we still use binascii for non-hex operations
179 ↗	(On Diff #61236)	TIL that `int(..., 16)` accepts ascii encoded hex strings >>> int("f", 16) 15 >>> int(b"f", 16) 15 >>> int(b"\x0f", 16) Traceback (most recent call last): File "<stdin>", line 1, in <module> ValueError: invalid literal for int() with base 16: b'\x0f' >>> >>> >>> int(b"spam", 16) Traceback (most recent call last): File "<stdin>", line 1, in <module> ValueError: invalid literal for int() with base 16: b'spam' >>> >>> int("dead", 16) 57005 >>> int(b"dead", 16) 57005 >>> int(b"\xde\xad", 16) Traceback (most recent call last): File "<stdin>", line 1, in <module>
electrum/electrumabc_plugins/digitalbitbox/digitalbitbox.py
133 ↗	(On Diff #61236)	and whatever uses this return value seems to expect the bytes return type... untestable, we don't have access to a digitalbitbox device