⚙ D20595 [monorepo] Upgrade pnpm to 12.3.4

bytesofman created this revision.Tue, Sep 8, 18:59

bytesofman held this revision as a draft.

Drop corepack disable from TeamCity jobs; pin with npm install -g pnpm@12.3.4 only.

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Your cache invalidation strategy is 'vibes and hope'.

────────────────────────────────────────────────────────────────────────

major [Stability & Availability]
→ ]8;;vscode://file//work/modules/ecashaddrjs/Dockerfile:7modules/ecashaddrjs/Dockerfile:7]8;;

Use a Node.js version supported by pnpm 12.

pnpm@12.3.4 declares node >=18.*, but this image uses
node:16-buster-slim. The later pnpm install and pnpm publish
commands can fail under Node.js 16. Update the base image to Node.js 22,
or use a pnpm release that supports Node.js 16.

────────────────────────────────────────────────────────────────────────

major [Stability & Availability]
→ ]8;;vscode://file//work/ecashaddrjs.Dockerfile:7ecashaddrjs.Dockerfile:7]8;;

Use a Node.js runtime supported by pnpm 12.

node:16-buster-slim cannot install or run pnpm@12.3.4. Use Node.js
22.13 or newer, or pin a pnpm release that supports Node.js 16 and this
project's lockfile format.

────────────────────────────────────────
Review complete
2 findings ✔

Major 2

28 files reviewed:

CONTRIBUTING.md
apps/marlin-wallet/web/install-dependencies.sh
b58-ts.Dockerfile
cashtab-connect.Dockerfile
cashtab-faucet.Dockerfile
cashtab.Dockerfile
cashtab/install-deps.sh
charts.e.cash.Dockerfile
chronik-client.Dockerfile
contrib/teamcity/build-configurations.yml

... and 18 more files
────────────────────────────────────────

Print all AI prompts: coderabbit review --show-prompts

Harbormaster completed remote builds in B38114: Diff 61261.Tue, Sep 8, 19:31

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) If programmers were electricians, parallel programmers would be bomb disposal experts. Both cut wires. - Bartosz Milewski

────────────────────────────────────────────────────────────────────────

major [Functional Correctness]
→ ]8;;vscode://file//work/modules/ecashaddrjs/Dockerfile:7modules/ecashaddrjs/Dockerfile:7]8;;

Use a Node.js version supported by pnpm 12.

This image uses node:16-buster-slim, but installs pnpm@12.3.4. pnpm 12
does not support Node.js 16, so the later pnpm install step may fail.

-FROM node:16-buster-slim
+FROM node:22-bookworm-slim

────────────────────────────────────────
Review complete
1 finding ✔

Major 1

28 files reviewed:

CONTRIBUTING.md
apps/marlin-wallet/web/install-dependencies.sh
b58-ts.Dockerfile
cashtab-connect.Dockerfile
cashtab-faucet.Dockerfile
cashtab.Dockerfile
cashtab/install-deps.sh
charts.e.cash.Dockerfile
chronik-client.Dockerfile
contrib/teamcity/build-configurations.yml

... and 18 more files
────────────────────────────────────────

Print all AI prompts: coderabbit review --show-prompts

Harbormaster completed remote builds in B38115: Diff 61262.Tue, Sep 8, 20:00

Bump leftover ecashaddrjs publish image from node:16-buster-slim to node:22-bookworm-slim so pnpm 12 can run.

Rebase onto master after D20594; keep Docker/CI pin at 12.3.4 (not 10.34.5).

Rebase onto D20594 and delete unused modules/ecashaddrjs/Dockerfile (publish uses repo-root ecashaddrjs.Dockerfile).

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Finish what you start. Where possible, the routine or object that allocates a resource should be responsible for deallocating it.

────────────────────────────────────────
Review complete
No findings ✔

28 files reviewed:

CONTRIBUTING.md
apps/marlin-wallet/web/install-dependencies.sh
b58-ts.Dockerfile
cashtab-connect.Dockerfile
cashtab-faucet.Dockerfile
cashtab.Dockerfile
cashtab/install-deps.sh
charts.e.cash.Dockerfile
chronik-client.Dockerfile
contrib/teamcity/build-configurations.yml

... and 18 more files
────────────────────────────────────────

Harbormaster completed remote builds in B38118: Diff 61265.Wed, Sep 9, 03:58

Harbormaster completed remote builds in B38119: Diff 61267.Wed, Sep 9, 04:17

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Your code is like a magic trick: now you see it... now it's undefined.

────────────────────────────────────────────────────────────────────────

major [Data Integrity & Integration]
→ ]8;;vscode://file//work/package.json:3package.json:3]8;;

Regenerate and commit pnpm-lock.yaml with pnpm 12.3.4.

If pmOnFail: ignore is not configured, frozen installs can fail with
ERR_PNPM_FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILE when
packageManagerDependencies does not match package.json.

────────────────────────────────────────
Review complete
1 finding ✔

Major 1

28 files reviewed:

CONTRIBUTING.md
apps/marlin-wallet/web/install-dependencies.sh
b58-ts.Dockerfile
cashtab-connect.Dockerfile
cashtab-faucet.Dockerfile
cashtab.Dockerfile
cashtab/install-deps.sh
charts.e.cash.Dockerfile
chronik-client.Dockerfile
contrib/teamcity/build-configurations.yml

... and 18 more files
────────────────────────────────────────

Print all AI prompts: coderabbit review --show-prompts

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Here's Johnny! Ready to axe those bugs.

────────────────────────────────────────
Review complete
No findings ✔

28 files reviewed:

CONTRIBUTING.md
apps/marlin-wallet/web/install-dependencies.sh
b58-ts.Dockerfile
cashtab-connect.Dockerfile
cashtab-faucet.Dockerfile
cashtab.Dockerfile
cashtab/install-deps.sh
charts.e.cash.Dockerfile
chronik-client.Dockerfile
contrib/teamcity/build-configurations.yml

... and 18 more files
────────────────────────────────────────

Harbormaster completed remote builds in B38120: Diff 61268.Wed, Sep 9, 04:28

Build Bitcoin ABC Diffs / Diff Testing (chronik-client-integration-tests) failed.

Failed tests logs:

====== Test expected websocket behavior of chronik-client: After this block is avalanche parked.Test expected websocket behavior of chronik-client After this block is avalanche parked ======
AssertionError: expected undefined to deeply equal { type: 'Tx', …(2) }
    at Context.<anonymous> (test/integration/websocket.ts:854:42)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)

      + expected - actual:  failed to generate Mocha diff

Each failure log is accessible here:
Test expected websocket behavior of chronik-client: After this block is avalanche parked.Test expected websocket behavior of chronik-client After this block is avalanche parked

bytesofman mentioned this in D20599: [chronik-client] Wait for both ws msgs after mine and avalanche park.Wed, Sep 9, 06:52

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) I see you chose the 'dynamic typing' difficulty setting. On purpose.

────────────────────────────────────────
Review complete
No findings ✔

28 files reviewed:

CONTRIBUTING.md
apps/marlin-wallet/web/install-dependencies.sh
b58-ts.Dockerfile
cashtab-connect.Dockerfile
cashtab-faucet.Dockerfile
cashtab.Dockerfile
cashtab/install-deps.sh
charts.e.cash.Dockerfile
chronik-client.Dockerfile
contrib/teamcity/build-configurations.yml

... and 18 more files
────────────────────────────────────────

bytesofman mentioned this in rABCb34958f2b334: [chronik-client] Wait for both ws msgs after mine and avalanche park.Wed, Sep 9, 07:51

Rebase onto latest master (ws flake fix + unused Dockerfile already landed). Lockfile still generated by pnpm 12.3.4; frozen install and fetch succeed.

Harbormaster completed remote builds in B38123: Diff 61273.Wed, Sep 9, 08:35

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Here comes the bug bouncer.

────────────────────────────────────────────────────────────────────────

minor [Data Integrity & Integration]
→ ]8;;vscode://file//work/package.json:3package.json:3]8;;

Synchronize pnpm-lock.yaml with pnpm@12.3.4.

pnpm 12 records the resolved package-manager version in pnpm-lock.yaml.
Dockerfiles use pnpm install --frozen-lockfile, so the unchanged
lockfile can fail image builds with
ERR_PNPM_FROZEN_LOCKFILE_WITH_OUTDATED_LOCKFILE. Run `pnpm install
--lockfile-only` with pnpm 12.3.4 and commit the resulting lockfile
changes.

────────────────────────────────────────
Review complete
1 finding ✔

Minor 1

27 files reviewed:

CONTRIBUTING.md
apps/marlin-wallet/web/install-dependencies.sh
b58-ts.Dockerfile
cashtab-connect.Dockerfile
cashtab-faucet.Dockerfile
cashtab.Dockerfile
cashtab/install-deps.sh
charts.e.cash.Dockerfile
chronik-client.Dockerfile
contrib/teamcity/build-configurations.yml

... and 17 more files
────────────────────────────────────────

Print all AI prompts: coderabbit review --show-prompts

bytesofman published this revision for review.Wed, Sep 9, 08:41

bytesofman added inline comments.

apps/marlin-wallet/web/install-dependencies.sh
25 ↗	(On Diff #61273)	the `--frozen-lockfile` flag is not supported for `pnpm fetch` in 12

PiRK accepted this revision.Wed, Sep 9, 13:38

This revision is now accepted and ready to land.Wed, Sep 9, 13:38

Rebase onto latest master.

Harbormaster completed remote builds in B38187: Diff 61367.Mon, Sep 14, 08:31

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Never bring a script to a dependency battle - bring a lockfile.

────────────────────────────────────────────────────────────────────────

major [Stability & Availability]
→ ]8;;vscode://file//work/package.json:3package.json:3]8;;

Regenerate pnpm-lock.yaml for pnpm 12.3.4

package.json pins pnpm 12.3.4, but the lockfile lacks matching
packageManagerDependencies metadata. The Docker and CI frozen installs
can reject this outdated lockfile before building. Regenerate and commit
pnpm-lock.yaml with pnpm 12.3.4.

────────────────────────────────────────
Review complete
1 finding ✔

Major 1

27 files reviewed:

CONTRIBUTING.md
apps/marlin-wallet/web/install-dependencies.sh
b58-ts.Dockerfile
cashtab-connect.Dockerfile
cashtab-faucet.Dockerfile
cashtab.Dockerfile
cashtab/install-deps.sh
charts.e.cash.Dockerfile
chronik-client.Dockerfile
contrib/teamcity/build-configurations.yml

... and 17 more files
────────────────────────────────────────

Print all AI prompts: coderabbit review --show-prompts

Closed by commit rABC35bd61985f5e: [monorepo] Upgrade pnpm to 12.3.4. · Explain WhyMon, Sep 14, 08:38

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC35bd61985f5e: [monorepo] Upgrade pnpm to 12.3.4.

[monorepo] Upgrade pnpm to 12.3.4
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 61375

CONTRIBUTING.md

apps/marlin-wallet/web/install-dependencies.sh

b58-ts.Dockerfile

cashtab-connect.Dockerfile

cashtab-faucet.Dockerfile

cashtab.Dockerfile

cashtab/install-deps.sh

charts.e.cash.Dockerfile

chronik-client.Dockerfile

contrib/teamcity/build-configurations.yml

contrib/utils/install-dependencies-bookworm.sh

docs.e.cash.Dockerfile

e.cash.Dockerfile

ecash-agora.Dockerfile

ecash-herald.Dockerfile

ecash-lib.Dockerfile

ecash-wallet.Dockerfile

ecashaddrjs.Dockerfile

faucet.Dockerfile

marlin-wallet.Dockerfile

metachronik.Dockerfile

mock-chronik-client.Dockerfile

notifications-server.Dockerfile

package.json

pnpm-lock.yaml

pnpm-workspace.yaml

token-server.Dockerfile

[monorepo] Upgrade pnpm to 12.3.4ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 61375

CONTRIBUTING.md

apps/marlin-wallet/web/install-dependencies.sh

b58-ts.Dockerfile

cashtab-connect.Dockerfile

cashtab-faucet.Dockerfile

cashtab.Dockerfile

cashtab/install-deps.sh

charts.e.cash.Dockerfile

chronik-client.Dockerfile

contrib/teamcity/build-configurations.yml

contrib/utils/install-dependencies-bookworm.sh

docs.e.cash.Dockerfile

e.cash.Dockerfile

ecash-agora.Dockerfile

ecash-herald.Dockerfile

ecash-lib.Dockerfile

ecash-wallet.Dockerfile

ecashaddrjs.Dockerfile

faucet.Dockerfile

marlin-wallet.Dockerfile

metachronik.Dockerfile

mock-chronik-client.Dockerfile

notifications-server.Dockerfile

package.json

pnpm-lock.yaml

pnpm-workspace.yaml

token-server.Dockerfile

[monorepo] Upgrade pnpm to 12.3.4
ClosedPublic
Actions

Revision Contents
Changeset List