The in-module Dockerfile is unused (build and publish use the
repo-root ecashaddrjs.Dockerfile) and pins node:16-buster-slim.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC72aaf52d497f: [ecashaddrjs] Remove unused Node 16 Dockerfile
- Confirm nothing references modules/ecashaddrjs/Dockerfile
- Confirm repo-root ecashaddrjs.Dockerfile still builds/publishes the package
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) I had to scroll so far I hit the heat death of the universe.
────────────────────────────────────────
Review complete
No findings ✔
1 file reviewed:
- modules/ecashaddrjs/Dockerfile
────────────────────────────────────────