test: make the sleep interval optional in wait_for_debug_log
ClosedPublic
Actions

Authored by PiRK on Wed, Sep 9, 09:30.

Project Tags

None

Referenced Files

	F86007084: D20600.1791415534.diff
	Tue, Oct 6, 23:25

	F86007083: D20600.1791415532.diff
	Tue, Oct 6, 23:25

	F86007081: D20600.1791415528.diff
	Tue, Oct 6, 23:25

	F86005922: D20600.1791406005.diff
	Tue, Oct 6, 20:46

	F85998903: D20600.1791381509.diff
	Tue, Oct 6, 13:58

Subscribers

None

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC908dfae7c725: test: make the sleep interval optional in wait_for_debug_log

Summary

D12983 added a sleep in wait_for_debug_log. But in some rare instances we want the loop to run as fast as possible to improve the test's chances of being meaningful.
For instance in feature_init.py we want to test that the node does not crash during some sensitive operations, so we want to sigterm ASAP after a message appears in the debug log.

Ref core#30006

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Sep 9, 09:30

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Sep 9, 09:30

PiRK requested review of this revision.Wed, Sep 9, 09:30

teamcity edited the summary of this revision. (Show Details)Wed, Sep 9, 09:30

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) I'm approving this in spirit, but not in Git.

────────────────────────────────────────────────────────────────────────

minor [Performance & Scalability]
→ ]8;;vscode://file//work/test/functional/test_framework/test_node.py:678test/functional/test_framework/test_node.py:678]8;;

Avoid tight polling when interval is None.

The new optional interval path repeatedly opens and reads the debug log
without a delay. test/functional/feature_init.py uses this path for
every termination point, which can consume a CPU and add filesystem load
on CI runners. Keep a positive polling interval, or replace this path with
a blocking notification mechanism.






Also applies to: 719-720

────────────────────────────────────────
Review complete
1 finding ✔

Minor 1

2 files reviewed: