Project Tags

None

Referenced Files

	F86000656: D20608.1791387407.diff
	Tue, Oct 6, 15:36

	F86000550: D20608.1791386978.diff
	Tue, Oct 6, 15:29

Subscribers

Fabien

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCb44e0d387040: consensus: Store transaction nVersion as uint32_t

Summary

Given that the use of a transaction's nVersion is always as an unsigned
int, it doesn't make sense to store it as signed and then cast it to
unsigned.

This is a partial backport of core#29325
https://github.com/bitcoin/bitcoin/pull/29325/changes/27e70f1f5be1f536f2314cd2ea42b4f80d927fbd

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Thu, Sep 10, 10:40

PiRK held this revision as a draft.

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Sep 10, 10:40

teamcity edited the summary of this revision. (Show Details)Thu, Sep 10, 10:40

fix BAD_VERSIONS in feature_tx_version.py

Harbormaster completed remote builds in B38139: Diff 61308.Thu, Sep 10, 10:49

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_tx_version.py ======

------- Stdout: -------
2026-09-10T10:47:58.426000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20260910_104643_61970/feature_tx_version_158
2026-09-10T10:47:58.946000Z TestFramework (INFO): These are always OK for the mempool
2026-09-10T10:47:59.047000Z TestFramework (INFO): Bad versions always rejected from mempool
2026-09-10T10:47:59.047000Z TestFramework (ERROR): Unexpected exception
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 155, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/feature_tx_version.py", line 86, in run_test
    bad_version_txs = test_mempool_rejects_bad_versions()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/feature_tx_version.py", line 75, in test_mempool_rejects_bad_versions
    tx = self.make_tx(spendable_tx, nVersion=bad_version)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/feature_tx_version.py", line 110, in make_tx
    pad_tx(tx)
  File "/work/test/functional/test_framework/txtools.py", line 29, in pad_tx
    curr_size = len(tx.serialize())
                    ^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/messages.py", line 438, in serialize
    self.nVersion.to_bytes(4, "little")
OverflowError: can't convert negative int to unsigned
2026-09-10T10:47:59.099000Z TestFramework (INFO): Not stopping nodes as test failed. The dangling processes will be cleaned up later.
2026-09-10T10:47:59.099000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20260910_104643_61970/feature_tx_version_158
2026-09-10T10:47:59.099000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20260910_104643_61970/feature_tx_version_158/test_framework.log
2026-09-10T10:47:59.099000Z TestFramework (ERROR): 
2026-09-10T10:47:59.099000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20260910_104643_61970/feature_tx_version_158' to consolidate all logs
2026-09-10T10:47:59.099000Z TestFramework (ERROR): 
2026-09-10T10:47:59.099000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2026-09-10T10:47:59.099000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2026-09-10T10:47:59.099000Z TestFramework (ERROR):
------- Stderr: -------
[node 0] Cleaning up leftover process

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_tx_version.py

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_tx_version.py ======

------- Stdout: -------
2026-09-10T10:51:14.956000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20260910_104722_105/feature_tx_version_158
2026-09-10T10:51:16.143000Z TestFramework (INFO): These are always OK for the mempool
2026-09-10T10:51:16.246000Z TestFramework (INFO): Bad versions always rejected from mempool
2026-09-10T10:51:16.246000Z TestFramework (ERROR): Unexpected exception
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 155, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/feature_tx_version.py", line 86, in run_test
    bad_version_txs = test_mempool_rejects_bad_versions()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/feature_tx_version.py", line 75, in test_mempool_rejects_bad_versions
    tx = self.make_tx(spendable_tx, nVersion=bad_version)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/feature_tx_version.py", line 110, in make_tx
    pad_tx(tx)
  File "/work/test/functional/test_framework/txtools.py", line 29, in pad_tx
    curr_size = len(tx.serialize())
                    ^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/messages.py", line 438, in serialize
    self.nVersion.to_bytes(4, "little")
OverflowError: can't convert negative int to unsigned
2026-09-10T10:51:16.298000Z TestFramework (INFO): Not stopping nodes as test failed. The dangling processes will be cleaned up later.
2026-09-10T10:51:16.298000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20260910_104722_105/feature_tx_version_158
2026-09-10T10:51:16.298000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20260910_104722_105/feature_tx_version_158/test_framework.log
2026-09-10T10:51:16.298000Z TestFramework (ERROR): 
2026-09-10T10:51:16.298000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-debug/test/tmp/test_runner_₿₵_🏃_20260910_104722_105/feature_tx_version_158' to consolidate all logs
2026-09-10T10:51:16.298000Z TestFramework (ERROR): 
2026-09-10T10:51:16.298000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2026-09-10T10:51:16.298000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2026-09-10T10:51:16.299000Z TestFramework (ERROR):
------- Stderr: -------
[node 0] Cleaning up leftover process

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_tx_version.py

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_tx_version.py ======

------- Stdout: -------
2026-09-10T10:50:35.233000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20260910_104835_64898/feature_tx_version_158
2026-09-10T10:50:35.757000Z TestFramework (INFO): These are always OK for the mempool
2026-09-10T10:50:35.859000Z TestFramework (INFO): Bad versions always rejected from mempool
2026-09-10T10:50:35.859000Z TestFramework (ERROR): Unexpected exception
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 155, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/feature_tx_version.py", line 86, in run_test
    bad_version_txs = test_mempool_rejects_bad_versions()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/feature_tx_version.py", line 75, in test_mempool_rejects_bad_versions
    tx = self.make_tx(spendable_tx, nVersion=bad_version)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/feature_tx_version.py", line 110, in make_tx
    pad_tx(tx)
  File "/work/test/functional/test_framework/txtools.py", line 29, in pad_tx
    curr_size = len(tx.serialize())
                    ^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/messages.py", line 438, in serialize
    self.nVersion.to_bytes(4, "little")
OverflowError: can't convert negative int to unsigned
2026-09-10T10:50:35.911000Z TestFramework (INFO): Not stopping nodes as test failed. The dangling processes will be cleaned up later.
2026-09-10T10:50:35.912000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20260910_104835_64898/feature_tx_version_158
2026-09-10T10:50:35.912000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20260910_104835_64898/feature_tx_version_158/test_framework.log
2026-09-10T10:50:35.912000Z TestFramework (ERROR): 
2026-09-10T10:50:35.912000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20260910_104835_64898/feature_tx_version_158' to consolidate all logs
2026-09-10T10:50:35.912000Z TestFramework (ERROR): 
2026-09-10T10:50:35.912000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2026-09-10T10:50:35.912000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2026-09-10T10:50:35.912000Z TestFramework (ERROR):
------- Stderr: -------
[node 0] Cleaning up leftover process
====== Bitcoin ABC functional tests with the next upgrade activated: feature_tx_version.py ======

------- Stdout: -------
2026-09-10T10:52:23.095000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20260910_105048_26516/feature_tx_version_158
2026-09-10T10:52:23.622000Z TestFramework (INFO): These are always OK for the mempool
2026-09-10T10:52:23.724000Z TestFramework (INFO): Bad versions always rejected from mempool
2026-09-10T10:52:23.724000Z TestFramework (ERROR): Unexpected exception
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 155, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/feature_tx_version.py", line 86, in run_test
    bad_version_txs = test_mempool_rejects_bad_versions()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/feature_tx_version.py", line 75, in test_mempool_rejects_bad_versions
    tx = self.make_tx(spendable_tx, nVersion=bad_version)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/feature_tx_version.py", line 110, in make_tx
    pad_tx(tx)
  File "/work/test/functional/test_framework/txtools.py", line 29, in pad_tx
    curr_size = len(tx.serialize())
                    ^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/messages.py", line 438, in serialize
    self.nVersion.to_bytes(4, "little")
OverflowError: can't convert negative int to unsigned
2026-09-10T10:52:23.775000Z TestFramework (INFO): Not stopping nodes as test failed. The dangling processes will be cleaned up later.
2026-09-10T10:52:23.775000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20260910_105048_26516/feature_tx_version_158
2026-09-10T10:52:23.775000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20260910_105048_26516/feature_tx_version_158/test_framework.log
2026-09-10T10:52:23.775000Z TestFramework (ERROR): 
2026-09-10T10:52:23.775000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20260910_105048_26516/feature_tx_version_158' to consolidate all logs
2026-09-10T10:52:23.775000Z TestFramework (ERROR): 
2026-09-10T10:52:23.775000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2026-09-10T10:52:23.775000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2026-09-10T10:52:23.775000Z TestFramework (ERROR):
------- Stderr: -------
[node 0] Cleaning up leftover process

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_tx_version.py
Bitcoin ABC functional tests with the next upgrade activated: feature_tx_version.py

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) There are no final decisions. No decision is cast in stone. Instead, consider each as being written in the sand at the beach, and plan for change.

────────────────────────────────────────────────────────────────────────

minor [Functional Correctness]
→ ]8;;vscode://file//work/test/functional/test_framework/messages.py:428test/functional/test_framework/messages.py:428]8;;

Reject a truncated lock-time field.

int.from_bytes() accepts an empty or short read. A transaction that ends
after empty vin and vout now deserializes with nLockTime == 0
instead of failing. Read exactly four bytes before decoding this field.

major [Data Integrity & Integration]
→ ]8;;vscode://file//work/chronik/chronik-proto/proto/chronik.proto:88chronik/chronik-proto/proto/chronik.proto:88]8;;

Update the public schema migration.

Tx.version is generated by prost_build and exposed directly by
chronik_proto::proto::Tx. Changing int32 to uint32 changes generated
client field types and can decode a negative value such as -1 as
4294967295. Chronik uses protobuf responses, so the impact is on the
protobuf contract rather than JSON. Publish this as a breaking API change
and regenerate and release every client that consumes Tx.version, or
keep the field as int32.

────────────────────────────────────────
Review complete
2 findings ✔

Major 1
Minor 1

14 files reviewed:

chronik/bitcoinsuite-core/src/tx/tx.rs
chronik/chronik-bridge/src/ffi.rs
chronik/chronik-proto/proto/chronik.proto
src/bitcoin-tx.cpp
src/consensus/tx_verify.cpp
src/core_write.cpp
src/primitives/transaction.cpp
src/primitives/transaction.h
src/rpc/rawtransaction.cpp
src/script/interpreter.cpp

... and 4 more files
────────────────────────────────────────

Print all AI prompts: coderabbit review --show-prompts

Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_tx_version.py ======

------- Stdout: -------
2026-09-10T11:00:10.420000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20260910_105805_23589/feature_tx_version_158
2026-09-10T11:00:10.947000Z TestFramework (INFO): These are always OK for the mempool
2026-09-10T11:00:11.051000Z TestFramework (INFO): Bad versions always rejected from mempool
2026-09-10T11:00:11.051000Z TestFramework (ERROR): Unexpected exception
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 155, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/feature_tx_version.py", line 86, in run_test
    bad_version_txs = test_mempool_rejects_bad_versions()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/feature_tx_version.py", line 75, in test_mempool_rejects_bad_versions
    tx = self.make_tx(spendable_tx, nVersion=bad_version)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/feature_tx_version.py", line 110, in make_tx
    pad_tx(tx)
  File "/work/test/functional/test_framework/txtools.py", line 29, in pad_tx
    curr_size = len(tx.serialize())
                    ^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/messages.py", line 438, in serialize
    self.nVersion.to_bytes(4, "little")
OverflowError: can't convert negative int to unsigned
2026-09-10T11:00:11.103000Z TestFramework (INFO): Not stopping nodes as test failed. The dangling processes will be cleaned up later.
2026-09-10T11:00:11.103000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20260910_105805_23589/feature_tx_version_158
2026-09-10T11:00:11.103000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20260910_105805_23589/feature_tx_version_158/test_framework.log
2026-09-10T11:00:11.103000Z TestFramework (ERROR): 
2026-09-10T11:00:11.103000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-chronik/test/tmp/test_runner_₿₵_🏃_20260910_105805_23589/feature_tx_version_158' to consolidate all logs
2026-09-10T11:00:11.103000Z TestFramework (ERROR): 
2026-09-10T11:00:11.103000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2026-09-10T11:00:11.103000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2026-09-10T11:00:11.103000Z TestFramework (ERROR):
------- Stderr: -------
[node 0] Cleaning up leftover process

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_tx_version.py

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) It is better to have 100 functions operate on one data structure than 10 functions on 10 data structures. - Alan Perlis

minor [Functional Correctness]
→ ]8;;vscode://file//work/test/functional/test_framework/messages.py:425test/functional/test_framework/messages.py:425]8;;

Require all four bytes for fixed-width fields.

int.from_bytes accepts a short read. A transaction truncated in
nLockTime can deserialize successfully with a different value. Preserve
the prior exact-width behavior while reading the version as unsigned.


Proposed fix

-        self.nVersion = int.from_bytes(f.read(4), "little")
+        self.nVersion = struct.unpack("<I", f.read(4))[0]
...
-        self.nLockTime = int.from_bytes(f.read(4), "little")
+        self.nLockTime = struct.unpack("<I", f.read(4))[0]

Also applies to: 428-428

────────────────────────────────────────
Review complete
1 finding ✔

Minor 1

15 files reviewed:

chronik/bitcoinsuite-core/src/tx/tx.rs
chronik/chronik-bridge/src/ffi.rs
chronik/chronik-proto/proto/chronik.proto
src/bitcoin-tx.cpp
src/consensus/tx_verify.cpp
src/core_write.cpp
src/primitives/transaction.cpp
src/primitives/transaction.h
src/rpc/rawtransaction.cpp
src/script/interpreter.cpp

... and 5 more files
────────────────────────────────────────

Print all AI prompts: coderabbit review --show-prompts

Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: feature_tx_version.py ======

------- Stdout: -------
2026-09-10T11:25:03.885000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20260910_112258_21650/feature_tx_version_158
2026-09-10T11:25:04.412000Z TestFramework (INFO): These are always OK for the mempool
2026-09-10T11:25:04.515000Z TestFramework (INFO): Bad versions always rejected from mempool
2026-09-10T11:25:04.515000Z TestFramework (ERROR): Unexpected exception
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 155, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/feature_tx_version.py", line 86, in run_test
    bad_version_txs = test_mempool_rejects_bad_versions()
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/feature_tx_version.py", line 75, in test_mempool_rejects_bad_versions
    tx = self.make_tx(spendable_tx, nVersion=bad_version)
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/feature_tx_version.py", line 110, in make_tx
    pad_tx(tx)
  File "/work/test/functional/test_framework/txtools.py", line 29, in pad_tx
    curr_size = len(tx.serialize())
                    ^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/messages.py", line 438, in serialize
    self.nVersion.to_bytes(4, "little")
OverflowError: can't convert negative int to unsigned
2026-09-10T11:25:04.567000Z TestFramework (INFO): Not stopping nodes as test failed. The dangling processes will be cleaned up later.
2026-09-10T11:25:04.567000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20260910_112258_21650/feature_tx_version_158
2026-09-10T11:25:04.568000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20260910_112258_21650/feature_tx_version_158/test_framework.log
2026-09-10T11:25:04.568000Z TestFramework (ERROR): 
2026-09-10T11:25:04.568000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-chronik-plugins/test/tmp/test_runner_₿₵_🏃_20260910_112258_21650/feature_tx_version_158' to consolidate all logs
2026-09-10T11:25:04.568000Z TestFramework (ERROR): 
2026-09-10T11:25:04.568000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2026-09-10T11:25:04.568000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2026-09-10T11:25:04.568000Z TestFramework (ERROR):
------- Stderr: -------
[node 0] Cleaning up leftover process

Each failure log is accessible here:
Bitcoin ABC functional tests: feature_tx_version.py

Harbormaster completed remote builds in B38140: Diff 61309.Thu, Sep 10, 11:29

rebase on the struct.pack stack

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) That's not technical debt - that's technical *predatory lending*.

────────────────────────────────────────
Review complete
No findings ✔

15 files reviewed:

chronik/bitcoinsuite-core/src/tx/tx.rs
chronik/chronik-bridge/src/ffi.rs
chronik/chronik-proto/proto/chronik.proto
src/bitcoin-tx.cpp
src/consensus/tx_verify.cpp
src/core_write.cpp
src/primitives/transaction.cpp
src/primitives/transaction.h
src/rpc/rawtransaction.cpp
src/script/interpreter.cpp

... and 5 more files
────────────────────────────────────────

Harbormaster completed remote builds in B38155: Diff 61325.Thu, Sep 10, 14:43

PiRK published this revision for review.Thu, Sep 10, 17:20

PiRK added inline comments.Thu, Sep 10, 17:25

test/functional/feature_tx_version.py
26–29 ↗	(On Diff #61309)	>>> import numpy >>> >>> [hex(numpy.int32(x).astype(numpy.uint32)) for x in (-0x80000000, -0x7FFFFFFF, -2, -1)] ['0x80000000', '0x80000001', '0xfffffffe', '0xffffffff']

Fabien requested changes to this revision.Fri, Sep 11, 09:06

Fabien subscribed.

Fabien added inline comments.

src/primitives/transaction.h
195 ↗	(On Diff #61325)	revert to constexpr
src/test/transaction_tests.cpp
624 ↗	(On Diff #61325)	remove

This revision now requires changes to proceed.Fri, Sep 11, 09:06

revert to constexpr for CURRENT_VERSION and remove blank line

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) BOFH: Bunny of Friendly Help.

────────────────────────────────────────
Review complete
No findings ✔

15 files reviewed:

chronik/bitcoinsuite-core/src/tx/tx.rs
chronik/chronik-bridge/src/ffi.rs
chronik/chronik-proto/proto/chronik.proto
src/bitcoin-tx.cpp
src/consensus/tx_verify.cpp
src/core_write.cpp
src/primitives/transaction.cpp
src/primitives/transaction.h
src/rpc/rawtransaction.cpp
src/script/interpreter.cpp

... and 5 more files
────────────────────────────────────────

Harbormaster completed remote builds in B38162: Diff 61338.Fri, Sep 11, 11:44

Fabien accepted this revision.Fri, Sep 11, 12:13

This revision is now accepted and ready to land.Fri, Sep 11, 12:13

Closed by commit rABCb44e0d387040: consensus: Store transaction nVersion as uint32_t. · Explain WhyFri, Sep 11, 14:21

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCb44e0d387040: consensus: Store transaction nVersion as uint32_t.

D20620 wallet: Deduplicate Resend and ReacceptWalletTransactions

·Reviewers: Restricted Project

Mon, Sep 14, 09:32

Author: PiRK

Repository: rABC Bitcoin ABC

consensus: Store transaction nVersion as uint32_t
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 61346

chronik/bitcoinsuite-core/src/tx/tx.rs

chronik/chronik-bridge/src/ffi.rs

chronik/chronik-proto/proto/chronik.proto

src/bitcoin-tx.cpp

src/consensus/tx_verify.cpp

src/core_write.cpp

src/primitives/transaction.h

src/primitives/transaction.cpp

src/rpc/rawtransaction.cpp

src/script/interpreter.cpp

src/test/transaction_tests.cpp

test/functional/feature_tx_version.py

test/functional/rpc_packages.py

test/functional/rpc_rawtransaction.py

test/functional/test_framework/messages.py

consensus: Store transaction nVersion as uint32_tClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 61346

chronik/bitcoinsuite-core/src/tx/tx.rs

chronik/chronik-bridge/src/ffi.rs

chronik/chronik-proto/proto/chronik.proto

src/bitcoin-tx.cpp

src/consensus/tx_verify.cpp

src/core_write.cpp

src/primitives/transaction.h

src/primitives/transaction.cpp

src/rpc/rawtransaction.cpp

src/script/interpreter.cpp

src/test/transaction_tests.cpp

test/functional/feature_tx_version.py

test/functional/rpc_packages.py

test/functional/rpc_rawtransaction.py

test/functional/test_framework/messages.py

consensus: Store transaction nVersion as uint32_t
ClosedPublic
Actions

Revision Contents
Changeset List