Differential D20616

[CI] Use the default linker for the debian build
ClosedPublic
Actions

Authored by Fabien on Fri, Sep 11, 09:36.

Project Tags

None

Referenced Files

	F86026292: D20616.1791551924.diff
	Thu, Oct 8, 13:18

	F86023213: D20616.1791498592.diff
	Wed, Oct 7, 22:29

Subscribers

None

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC087d4f396e40: [CI] Use the default linker for the debian build

Summary

Gold is deprecated and no longer available on all distributions (this fails the build on Ubuntu 26.04).

We should consider changing the default but it's out of scope for this diff.

Test Plan

Trivial

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Fri, Sep 11, 09:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Sep 11, 09:36

Fabien requested review of this revision.Fri, Sep 11, 09:36

Syntax fix

Harbormaster completed remote builds in B38160: Diff 61330.Fri, Sep 11, 09:42

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Clippy called, he wants his job back.

────────────────────────────────────────────────────────────────────────

major [Functional Correctness]
→ ]8;;vscode://file//work/contrib/debian/rules:20contrib/debian/rules:20]8;;

Pass LD as the default linker value.

cmake/ConfigureCompiler.cmake rejects empty USE_LD values with `USE_LD
must be set to LD, GOLD, or LLD!. Use -DUSE_LD=LD`; this selects the
system-default linker without adding -fuse-ld.

────────────────────────────────────────
Review complete
1 finding ✔

Major 1

1 file reviewed:

contrib/debian/rules

────────────────────────────────────────

Print all AI prompts: coderabbit review --show-prompts

Harbormaster completed remote builds in B38161: Diff 61331.Fri, Sep 11, 09:44

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Review complete: I laughed, I cried, I filed issues.

────────────────────────────────────────
Review complete
No findings ✔

1 file reviewed:

contrib/debian/rules

────────────────────────────────────────

PiRK accepted this revision.Fri, Sep 11, 13:04

This revision is now accepted and ready to land.Fri, Sep 11, 13:04

Fix weird whitespace chars

Harbormaster completed remote builds in B38169: Diff 61345.Fri, Sep 11, 13:29

Build Bitcoin ABC Diffs / Diff Testing (ai-review) failed.

Tail of the build log:

/work /work/abc-ci-builds/ai-review
Connecting to CodeRabbit... 0s elapsed
Preparing review... 1s elapsed

  ✗ Review limit reached

  Limit details: You’ve used all 5 included reviews currently available.

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

Check out review usage here.
  You can wait 14 minutes for the limit to reset.
  https://app.coderabbit.ai/settings/billing?tab=usage&orgId=79839cd4-7849-4bd5-8d6d-5ecaf453356e
  https://app.coderabbit.ai/dashboard/review-capacity?orgId=79839cd4-7849-4bd5-8d6d-5ecaf453356e

Build ai-review failed with exit code 1

This revision was landed with ongoing or failed builds.Mon, Sep 14, 06:57

Closed by commit rABC087d4f396e40: [CI] Use the default linker for the debian build. · Explain Why

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC087d4f396e40: [CI] Use the default linker for the debian build.