ResendWalletTransactions() only executes every 12-36h (24h average).
Triggering it every second is excessive, once per minute should be
plenty.
This is a backport of core#25922
Differential D20617
wallet: trigger MaybeResendWalletTxs() every minute Authored by PiRK on Fri, Sep 11, 12:41. Project Tags None Referenced Files
Subscribers None Tokens
Details
ResendWalletTransactions() only executes every 12-36h (24h average). This is a backport of core#25922 ninja all check-all
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed. Diff : committed changes only (\(\ ──────────────────────────────────────────────────────────────────────── minor [Maintainability & Code Quality] → ]8;;vscode://file//work/test/functional/wallet_resendwallettransactions.py:30test/functional/wallet_resendwallettransactions.py:30]8;; Fix the time-unit typo in the scheduler comment. 1 min sec is ambiguous. Use 1 minute to match the 1min production interval and node.mockscheduler(60) calls. Proposed fix - # Wallet rebroadcast is first scheduled 1 min sec after startup (see + # Wallet rebroadcast is first scheduled 1 minute after startup (see ──────────────────────────────────────── Minor 1 2 files reviewed:
──────────────────────────────────────── Print all AI prompts: coderabbit review --show-prompts Comment Actions Build Bitcoin ABC Diffs / Diff Testing (ai-review) failed.
Tail of the build log: /work /work/abc-ci-builds/ai-review Connecting to CodeRabbit... 0s elapsed Preparing review... 1s elapsed ✗ Review limit reached Limit details: You’ve used all 5 included reviews currently available. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. You're only billed for reviews past your plan's rate limits ($0.25/file). Check out review usage here. You can wait 15 minutes for the limit to reset. https://app.coderabbit.ai/settings/billing?tab=usage&orgId=79839cd4-7849-4bd5-8d6d-5ecaf453356e https://app.coderabbit.ai/dashboard/review-capacity?orgId=79839cd4-7849-4bd5-8d6d-5ecaf453356e Build ai-review failed with exit code 1 Comment Actions Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed. Diff : committed changes only (\(\ ──────────────────────────────────────── 2 files reviewed:
──────────────────────────────────────── |