Stop decoding alias-spec registration txs; treat 2e786563 as an unknown LOKAD in parseTx, Cashtab, and Herald.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABCa4420c6e70d4: [ecash-parse] Drop eCash alias OP_RETURN parsing
cd modules/ecash-parse && npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) Stealth mode activated. Bugs won't see me coming.
────────────────────────────────────────
Review complete
No findings ✔
20 files reviewed:
- apps/ecash-herald/config.ts
- apps/ecash-herald/constants/op_return.ts
- apps/ecash-herald/scripts/generateMock.ts
- apps/ecash-herald/src/parse.ts
- apps/ecash-herald/test/mocks/appTxSamples.ts
- apps/ecash-herald/test/mocks/block.ts
- apps/ecash-herald/test/parse.test.ts
- cashtab/src/assets/alias.svg
- cashtab/src/chronik/fixtures/mocks.js
- cashtab/src/components/Common/CustomIcons.tsx
... and 10 more files
────────────────────────────────────────