Differential D20622
validation: Check if mempool exists before asserting in ActivateSnapshot Authored by PiRK on Fri, Sep 11, 15:47.
Details
This is mostly for consistency with how the mempool is accessed in other parts of the codebase. For now we don't expect the active chainstate to not have a mempool. This is a backport of core#30388 ninja all check-all
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed. Diff : committed changes only (\(\ ──────────────────────────────────────────────────────────────────────── critical [Stability & Availability]
→ ]8;;vscode://file//work/src/validation.cpp:6709src/validation.cpp:6709-6710]8;;
Guard the later mempool assertion before allowing a null mempool.
When GetMempool() returns null, this condition allows activation to
continue. Line 6827 later evaluates
m_active_chainstate->m_mempool->size(), which dereferences the null
pointer before ownership transfer. Snapshot activation therefore crashes
for chainstates without a mempool. Guard that assertion and transfer the
null pointer unchanged, or reject the null mempool here.
🐛 Proposed fix
- Assert(m_active_chainstate->m_mempool->size() == 0);
+ if (m_active_chainstate->m_mempool) {
+ Assert(m_active_chainstate->m_mempool->size() == 0);
+ }──────────────────────────────────────── Critical 1 1 file reviewed:
──────────────────────────────────────── Print all AI prompts: coderabbit review --show-prompts
Comment Actions check again for mempool's existence before asserting its size (this was later fixed by core in https://github.com/bitcoin/bitcoin/pull/33728/changes/2bc32656498517fe58bd41dcbd0afd306d51d4b0) Comment Actions Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.
Tail of the build log:
[5 bytes data]
[1 bytes data]
[5 bytes data]
[1 bytes data]
[5 bytes data]
[1 bytes data]
HTTP/2 504
content-length: 92
cache-control: no-cache
content-type: text/html
date: Mon, 14 Sep 2026 08:50:36 GMT
x-github-request-id: E106:1B8DC7:1EE7FE5:1C3CE0C:6AA7B551
x-github-edge-region: fra
x-frame-options: DENY
strict-transport-security: max-age=31536000; includeSubDomains; preload
The requested URL returned error: 504
Connection #0 to host github.com left intact
--- LOG END ---
FAILED: corrosion-populate-prefix/src/corrosion-populate-stamp/corrosion-populate-download /work/abc-ci-builds/build-clang-tidy/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/corrosion-populate-download
cd /work/abc-ci-builds/build-clang-tidy/_deps && /usr/bin/cmake -P /work/abc-ci-builds/build-clang-tidy/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/download-corrosion-populate.cmake && /usr/bin/cmake -P /work/abc-ci-builds/build-clang-tidy/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/verify-corrosion-populate.cmake && /usr/bin/cmake -P /work/abc-ci-builds/build-clang-tidy/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/extract-corrosion-populate.cmake && /usr/bin/cmake -E touch /work/abc-ci-builds/build-clang-tidy/_deps/corrosion-subbuild/corrosion-populate-prefix/src/corrosion-populate-stamp/corrosion-populate-download
ninja: build stopped: subcommand failed.
CMake Error at /usr/share/cmake-3.25/Modules/FetchContent.cmake:1616 (message):
Build step for corrosion failed: 1
Call Stack (most recent call first):
/usr/share/cmake-3.25/Modules/FetchContent.cmake:1756:EVAL:2 (__FetchContent_directPopulate)
/usr/share/cmake-3.25/Modules/FetchContent.cmake:1756 (cmake_language)
/usr/share/cmake-3.25/Modules/FetchContent.cmake:1970 (FetchContent_Populate)
cmake/modules/RustHelper.cmake:12 (FetchContent_MakeAvailable)
chronik/CMakeLists.txt:6 (include)
-- Configuring incomplete, errors occurred!
See also "/work/abc-ci-builds/build-clang-tidy/CMakeFiles/CMakeOutput.log".
See also "/work/abc-ci-builds/build-clang-tidy/CMakeFiles/CMakeError.log".
Build build-clang-tidy failed with exit code 1Comment Actions Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed. Diff : committed changes only (\(\ ──────────────────────────────────────── 1 file reviewed:
──────────────────────────────────────── | ||||||||||||||