Project Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

bytesofman
a2c.dev

Group Reviewers

Restricted Project
Restricted Owners Package	(Owns No Changed Paths)

Commits

rABC06b4b70beb6c: [Cashtab] Show XecVibe payment in tx history

Summary

Render XecVibe + memo (and Invalid XecVibe) in Home tx history.

Example txs (platform fee address, Sep 11):

f75728265da75a7f8e4223f7a50719358f0e9713c006dcebb0d2622e1d7cb308
c99ae17fbcbc9f17e20f57af31fb60b977452eede9182ebb02dbab85856db94c

Test Plan

cd cashtab && pnpm test src/components/Home/Tx/__tests__/index.test.js -t "Received XecVibe payment" --watchAll=false
On Cashtab web/app after this lands, open history for the txids above and confirm XecVibe + memo (not Unknown App)

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

a2c.dev created this revision.Sep 12 2026, 00:05

Owners added a reviewer: Restricted Owners Package.Sep 12 2026, 00:05

a2c.dev requested review of this revision.Sep 12 2026, 00:05

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Colonel Panic is my arch-nemesis.

────────────────────────────────────────
Review complete
No findings ✔

2 files reviewed:

cashtab/src/components/Home/Tx/__tests__/index.test.js
cashtab/src/components/Home/Tx/index.tsx

────────────────────────────────────────

Harbormaster completed remote builds in B38171: Diff 61348.Sep 12 2026, 00:13

[Cashtab] Show XecVibe in tx history

XECV payments parse correctly and Send preview labels them XecVibe, but
Home history fell through to Unknown App because Tx UI had no xecv case.

Summary:
Render XecVibe (and Invalid XecVibe) in Home tx history. Do not show the
opaque payment-id memo — same simple app label style as other apps.

Example txs (platform fee address, Sep 11):

f75728265da75a7f8e4223f7a50719358f0e9713c006dcebb0d2622e1d7cb308
c99ae17fbcbc9f17e20f57af31fb60b977452eede9182ebb02dbab85856db94c

Test Plan:

cd cashtab && pnpm test src/components/Home/Tx/__tests__/index.test.js -t "Received XecVibe payment" --watchAll=false
On Cashtab web/app after this lands, open history for the txids above and confirm XecVibe label only (not Unknown App, not the hex memo)

Reviewers: #bitcoin_abc, bytesofman

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) All your bugs are belong to us.

────────────────────────────────────────
Review complete
No findings ✔

2 files reviewed:

cashtab/src/components/Home/Tx/__tests__/index.test.js
cashtab/src/components/Home/Tx/index.tsx

────────────────────────────────────────

Harbormaster completed remote builds in B38172: Diff 61349.Sep 12 2026, 00:22

[Cashtab] Show XecVibe in tx history

Summary: Label XECV txs as XecVibe in Home history (was Unknown App).

Test Plan: cd cashtab && pnpm test src/components/Home/Tx/__tests__/index.test.js -t "Received XecVibe payment" --watchAll=false

Reviewers: #bitcoin_abc, bytesofman

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) CORS error? I've seen worse relationship issues.

────────────────────────────────────────
Review complete
No findings ✔

2 files reviewed:

cashtab/src/components/Home/Tx/__tests__/index.test.js
cashtab/src/components/Home/Tx/index.tsx

────────────────────────────────────────

Harbormaster completed remote builds in B38174: Diff 61351.Sep 12 2026, 00:33

Fabien requested changes to this revision.Sep 14 2026, 07:09

Fabien subscribed.

Fabien added inline comments.

cashtab/src/components/Home/Tx/index.tsx
835 ↗	(On Diff #61351)	That's unlikely to be the proper icon
837 ↗	(On Diff #61351)	Why no "XecVibe payment" like the herald ?

This revision now requires changes to proceed.Sep 14 2026, 07:09

[Cashtab] Show XecVibe in tx history

Summary: Label XECV txs as XecVibe payments in Home history.

Test Plan: cd cashtab && pnpm test src/components/Home/Tx/__tests__/index.test.js -t "Received XecVibe payment" --watchAll=false

Reviewers: #bitcoin_abc, bytesofman

Harbormaster completed remote builds in B38199: Diff 61387.Sep 14 2026, 15:46

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) RabbitMQ is just my side hustle.

────────────────────────────────────────
Review complete
No findings ✔

2 files reviewed:

cashtab/src/components/Home/Tx/__tests__/index.test.js
cashtab/src/components/Home/Tx/index.tsx

────────────────────────────────────────

Fabien requested changes to this revision.Sep 14 2026, 17:56

Fabien added inline comments.

cashtab/src/components/Home/Tx/index.tsx
836 ↗	(On Diff #61387)	I'm sure XecVibe has an icon

This revision now requires changes to proceed.Sep 14 2026, 17:56

[Cashtab] Show XecVibe in tx history

Summary: Label XECV txs as XecVibe payments in Home history.

Test Plan: cd cashtab && pnpm test src/components/Home/Tx/__tests__/index.test.js -t "Received XecVibe payment" --watchAll=false

Reviewers: #bitcoin_abc, bytesofman

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) You talkin' to me? You talkin' to me? Then who the hell else are you talking...you talking to me? Well, I'm the only one here. Who do the bugs think they're hiding from?

────────────────────────────────────────
Review complete
No findings ✔

4 files reviewed:

cashtab/src/assets/xecvibe-icon.svg
cashtab/src/components/Common/CustomIcons.tsx
cashtab/src/components/Home/Tx/__tests__/index.test.js
cashtab/src/components/Home/Tx/index.tsx

────────────────────────────────────────

Harbormaster completed remote builds in B38204: Diff 61392.Sep 14 2026, 18:28

Fix the linter

cashtab/src/components/Common/CustomIcons.tsx
9 ↗	(On Diff #61392)	what's the ?url ?

This revision now requires changes to proceed.Sep 14 2026, 18:30

[Cashtab] Show XecVibe in tx history

Summary: Label XECV txs as XecVibe payments in Home history.

Test Plan: cd cashtab && pnpm test src/components/Home/Tx/__tests__/index.test.js -t "Received XecVibe payment" --watchAll=false

Reviewers: #bitcoin_abc, bytesofman

Fix the linter and the title

cashtab/src/components/Common/CustomIcons.tsx
40 ↗	(On Diff #61395)	move at the end of the list, it's not sorted anyway

This revision now requires changes to proceed.Tue, Sep 15, 07:33

a2c.dev added a comment.Tue, Sep 15, 12:01

This comment was removed by a2c.dev.

[Cashtab] Show XecVibe in tx history

Summary: Label XECV txs as XecVibe payments in Home history.

Test Plan: cd cashtab && pnpm test src/components/Home/Tx/__tests__/index.test.js -t "Received XecVibe payment" --watchAll=false

Reviewers: #bitcoin_abc, bytesofman

Harbormaster completed remote builds in B38222: Diff 61418.Tue, Sep 15, 12:58

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) My GPUs are ready. Let's find some bugs.

────────────────────────────────────────
Review complete
No findings ✔

4 files reviewed:

cashtab/src/assets/xecvibe-icon.svg
cashtab/src/components/Common/CustomIcons.tsx
cashtab/src/components/Home/Tx/__tests__/index.test.js
cashtab/src/components/Home/Tx/index.tsx

────────────────────────────────────────

the diff title still has to be fixed

This revision now requires changes to proceed.Tue, Sep 15, 14:34

[Cashtab] Show XecVibe payment in tx history

Summary: Label XECV txs as XecVibe payments in Home history.

Test Plan: cd cashtab && pnpm test src/components/Home/Tx/__tests__/index.test.js -t "Received XecVibe payment" --watchAll=false

Reviewers: #bitcoin_abc, bytesofman

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Optimism is an occupational hazard of programming; feedback is the treatment. - Kent Beck

────────────────────────────────────────
Review complete
No findings ✔

4 files reviewed:

cashtab/src/assets/xecvibe-icon.svg
cashtab/src/components/Common/CustomIcons.tsx
cashtab/src/components/Home/Tx/__tests__/index.test.js
cashtab/src/components/Home/Tx/index.tsx

────────────────────────────────────────

Harbormaster completed remote builds in B38232: Diff 61431.Tue, Sep 15, 15:42

In D20623#469188, @a2c.dev wrote:

[Cashtab] Show XecVibe payment in tx history

Summary: Label XECV txs as XecVibe payments in Home history.

Test Plan: cd cashtab && pnpm test src/components/Home/Tx/__tests__/index.test.js -t "Received XecVibe payment" --watchAll=false

Reviewers: #bitcoin_abc, bytesofman

Use arc diff --edit to change the Diff title in the system

a2c.dev retitled this revision from [Cashtab] Show XecVibe in tx history XECV payments parse correctly and Send preview labels them XecVibe, but Home history fell through to Unknown App because Tx UI had no xecv case. to [Cashtab] Show XecVibe payment in tx history.Fri, Sep 18, 18:12

Fabien commandeered this revision.Mon, Sep 21, 07:25

Fabien edited reviewers, added: a2c.dev; removed: Fabien.

Rebase

Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review

Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────

(\(\
(• .•) Time zones: the final boss of software.

────────────────────────────────────────
Review complete
No findings ✔

4 files reviewed:

cashtab/src/assets/xecvibe-icon.svg
cashtab/src/components/Common/CustomIcons.tsx
cashtab/src/components/Home/Tx/__tests__/index.test.js
cashtab/src/components/Home/Tx/index.tsx

────────────────────────────────────────

bytesofman accepted this revision.Mon, Sep 21, 07:30

This revision is now accepted and ready to land.Mon, Sep 21, 07:30

Harbormaster completed remote builds in B38290: Diff 61520.Mon, Sep 21, 07:32

Closed by commit rABC06b4b70beb6c: [Cashtab] Show XecVibe payment in tx history. · Explain WhyMon, Sep 21, 07:36

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC06b4b70beb6c: [Cashtab] Show XecVibe payment in tx history.

[Cashtab] Show XecVibe payment in tx history
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 61521

cashtab/src/assets/xecvibe-icon.svg

cashtab/src/components/Common/CustomIcons.tsx

cashtab/src/components/Home/Tx/tests/index.test.js

cashtab/src/components/Home/Tx/index.tsx

[Cashtab] Show XecVibe payment in tx historyClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 61521

cashtab/src/assets/xecvibe-icon.svg

cashtab/src/components/Common/CustomIcons.tsx

cashtab/src/components/Home/Tx/__tests__/index.test.js

cashtab/src/components/Home/Tx/index.tsx

[Cashtab] Show XecVibe payment in tx history
ClosedPublic
Actions

Revision Contents
Changeset List

cashtab/src/components/Home/Tx/tests/index.test.js