This is a backport of core#21141 and core#21777
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABCe7d62e03ceef: Add new format string placeholders for walletnotify to include relevant block…
ninja all check-all
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) Your cache invalidation strategy is 'vibes and hope'.
────────────────────────────────────────────────────────────────────────
minor [Data Integrity & Integration] → ]8;;vscode://file//work/doc/release-notes.md:8doc/release-notes.md:8-9]8;; Correct the documented unconfirmed values. For an unconfirmed transaction, CWallet::AddToWallet substitutes unconfirmed for %b and -1 for %h. The release notes instead specify a zeroed hash and height 0. Update both values so users can parse wallet notifications correctly.
────────────────────────────────────────
Review complete
1 finding ✔
Minor 1
4 files reviewed:
- doc/release-notes.md
- src/wallet/init.cpp
- src/wallet/wallet.cpp
- test/functional/feature_notifications.py
────────────────────────────────────────
Print all AI prompts: coderabbit review --show-prompts
| doc/release-notes.md | ||
|---|---|---|
| 7–9 ↗ | (On Diff #61783) | |
Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed.
CodeRabbit Review
Diff : committed changes only
Compare : HEAD → master
Directory : work
────────────────────────────────────────
(\(\
(• .•) Good code is its own best documentation. As you're about to add a comment, ask yourself, 'How can I improve the code so that this comment isn't needed?' - Steve McConnell
────────────────────────────────────────
Review complete
No findings ✔
4 files reviewed:
- doc/release-notes.md
- src/wallet/init.cpp
- src/wallet/wallet.cpp
- test/functional/feature_notifications.py
────────────────────────────────────────