We don't always want to finalize after signing, so make it possible to
do that.
This is a backport of core#22513
Differential D20794
psbt: sign without finalizing Authored by PiRK on Oct 8 2026, 10:18. Project Tags None Referenced Files None Subscribers None
Details
We don't always want to finalize after signing, so make it possible to This is a backport of core#22513 ninja all check-all
Diff Detail
Event TimelineComment Actions Build Bitcoin ABC Diffs / Diff Testing (ai-review) passed. Diff : committed changes only (\(\ ──────────────────────────────────────────────────────────────────────── major [Functional Correctness] → ]8;;vscode://file//work/src/wallet/wallet.cpp:2169src/wallet/wallet.cpp:2169-2170]8;; Calculate complete for unfinalized signatures. When finalize=false, the script managers retain complete signatures without a final scriptSig. Line 2179 still uses PSBTInputSigned, so walletprocesspsbt returns complete=false even when every input is ready to finalize. Clients that use complete to advance the signing flow can stop incorrectly. Calculate completion from the signatures without modifying the returned PSBT, and test the complete result for this mode. ──────────────────────────────────────── Major 1 9 files reviewed:
──────────────────────────────────────── Print all AI prompts: coderabbit review --show-prompts |