make check
Details
Details
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- arcpatch-D2135 (branched from master)
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 4148 Build 6367: Bitcoin ABC Buildbot (legacy) Build 6366: arc lint + arc unit
Event Timeline
Comment Actions
I would advise strongly against moving these globals around unless you can ensure that initialization will be done in proper order. Initialization across modules is linker dependent, unless you want to specify it using a linker script so they'd better not depend on each other, which I wouldn't bet on.
src/Makefile.am | ||
---|---|---|
427 ↗ | (On Diff #6105) | This being included in 3 libraries indicate that it's likely none of these 3 places is actually correct. |
src/logging.cpp | ||
27 ↗ | (On Diff #6105) | Now you just lost any guarantees on initialization order. |
src/qt/bitcoingui.cpp | ||
1157 ↗ | (On Diff #6105) | The semantic isn't the same anymore. In addition it doesn't look like any of the changes int hat file is related to the diff. |
src/qt/coincontroldialog.cpp | ||
18 ↗ | (On Diff #6105) | Why twice ? |
src/Makefile.am | ||
---|---|---|
427 ↗ | (On Diff #6105) | Indeed. I'm having trouble with getting it to link. Not sure why: https://reviews.bitcoinabc.org/P21 |