Page MenuHomePhabricator

Add MakeUnique (substitute for C++14 std::make_unique)
ClosedPublic

Authored by Fabien on Dec 28 2018, 23:13.

Details

Summary

Partial backport of core PR11043

Backported commits are 8617989, 3e09b39 and a357293

Depends on D2229

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix requested changes to this revision.Dec 30 2018, 12:18

Why not upgrade to C++14 instead ?

This revision now requires changes to proceed.Dec 30 2018, 12:18

Upgrade to c++14 is a work in progress.
I still need to figure out how to make it work with openbsd ; there is no c++14 support built-in the gcc versions available, so I'm trying to make it build and work with clang.

This change could be easily upgraded to c++14 make_unique when it becomes available (the same with the reverse iterator, rbegin() and rend() are standard in c++14).
This will eventually avoid merge conflicts when backporting PR which depends on this in the meantime.

Fabien requested review of this revision.Dec 30 2018, 13:15
This revision is now accepted and ready to land.Dec 31 2018, 16:56