regarding a check that should be done in CCoinsViewMemPool, per the TODO comment.
- Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project
built and ran tests
It would be beneficial if you used arc to submit the patch instead so the linters and CI can run.
Does the lock need to be held when constructing the view ? If not, then the most obvious design choice is to move the lock in HasUnspent.
I'm not sure, but I do think this does not follow the formatting. If you install clang-format 4.0 , arc will format everything for you when submitting the patch.
This seems like a very dangerous design to me. This require a mutex to be held and it is hidden behind an abstraction.