Page MenuHomePhabricator

fixed pending TODO on rpc/blockchain.cpp
Needs RevisionPublic

Authored by gubatron on Mon, Jan 7, 17:56.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

regarding a check that should be done in CCoinsViewMemPool, per the TODO comment.

Test Plan

built and ran tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 4439
Build 6942: Bitcoin ABC Teamcity Staging

Event Timeline

gubatron created this revision.Mon, Jan 7, 17:56
Owners added a reviewer: Restricted Owners Package.Mon, Jan 7, 17:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Jan 7, 17:56
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Mon, Jan 7, 23:15

It would be beneficial if you used arc to submit the patch instead so the linters and CI can run.

src/rpc/blockchain.cpp
1112

Does the lock need to be held when constructing the view ? If not, then the most obvious design choice is to move the lock in HasUnspent.

src/txmempool.cpp
1102

I'm not sure, but I do think this does not follow the formatting. If you install clang-format 4.0 , arc will format everything for you when submitting the patch.

1103

This seems like a very dangerous design to me. This require a mutex to be held and it is hidden behind an abstraction.

This revision now requires changes to proceed.Mon, Jan 7, 23:15