fixed pending TODO on rpc/blockchain.cpp
Needs RevisionPublic
Actions

Authored by gubatron on Jan 7 2019, 17:56.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

regarding a check that should be done in CCoinsViewMemPool, per the TODO comment.

Test Plan

built and ran tests

Repository

rABC Bitcoin ABC

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 4439
Build 6942: Bitcoin ABC Buildbot (legacy)

Owners added a reviewer: Restricted Owners Package.Jan 7 2019, 17:56

It would be beneficial if you used arc to submit the patch instead so the linters and CI can run.

src/rpc/blockchain.cpp
1112	Does the lock need to be held when constructing the view ? If not, then the most obvious design choice is to move the lock in HasUnspent.
src/txmempool.cpp
1102	I'm not sure, but I do think this does not follow the formatting. If you install clang-format 4.0 , arc will format everything for you when submitting the patch.
1103	This seems like a very dangerous design to me. This require a mutex to be held and it is hidden behind an abstraction.