Page MenuHomePhabricator

[CMAKE] Add secp256k1 and univalue tests to the cmake check target
AbandonedPublic

Authored by Fabien on Feb 4 2019, 11:01.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

This mimics the behaviour of make check with autotools

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja check

Ensure that secp256k1 and univalue tests are run

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_run_secp256k1_tests
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4860
Build 7783: Bitcoin ABC Teamcity Staging
Build 7782: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 4 2019, 11:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 4 2019, 11:01
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Feb 4 2019, 11:48

They already run as part of check-all

This revision now requires changes to proceed.Feb 4 2019, 11:48
Fabien abandoned this revision.Thu, Feb 28, 08:09

After discussion, running libraries test suites as part of our standard check runs is not necessary, they can be run manually if needed through their own target or check-all