Page MenuHomePhabricator

Changed seeder README and main.cpp help message to reflect necessity of email and -m option.
AbandonedPublic

Authored by nakihito on Feb 23 2019, 00:31.

Details

Reviewers
Fabien
jasonbcox
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Updated seeder README and main.cpp help message to reflect the -m option requirement.

Test Plan

make check
./bitcoin-seeder -h seeder.bitframe.org -n dev.bitframe.org
./bitcoin-seeder -h seeder.bitframe.org -n dev.bitframe.org -m "<email>"

Diff Detail

Repository
rABC Bitcoin ABC
Branch
SeederHelp
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5050
Build 8163: Bitcoin ABC Buildbot (legacy)
Build 8162: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Feb 23 2019, 00:32
deadalnix requested changes to this revision.Feb 23 2019, 00:46

The test plan does not cover the change in any meaningful way.

This revision now requires changes to proceed.Feb 23 2019, 00:46

It's also unclear that the change actually reflects accurately the parameters requirements as if fDNS is not set, then the email is not required, which clearly indicate that in some situations, it is indeed optional.

nakihito removed a subscriber: schancel.

Sorry. I should have been more precise in my test method. I have updated it to reflect the commands I actually used to test this. The second command without the -m option failed with the following error message:

Supporting whitelisted filters: 0x1,0x5,0x11,0x15
No e-mail address set. Please use -m.

The third line succeeded.