diff --git a/test/functional/p2p_compactblocks.py b/test/functional/p2p_compactblocks.py --- a/test/functional/p2p_compactblocks.py +++ b/test/functional/p2p_compactblocks.py @@ -4,12 +4,47 @@ # Distributed under the MIT software license, see the accompanying # file COPYING or http://www.opensource.org/licenses/mit-license.php. -from test_framework.mininode import * -from test_framework.test_framework import BitcoinTestFramework -from test_framework.util import * +import random + from test_framework.blocktools import create_block, create_coinbase +from test_framework.messages import ( + BlockTransactions, + BlockTransactionsRequest, + calculate_shortid, + CBlock, + CBlockHeader, + CInv, + COutPoint, + CTransaction, + CTxIn, + CTxOut, + FromHex, + HeaderAndShortIDs, + msg_block, + msg_blocktxn, + msg_cmpctblock, + msg_getblocktxn, + msg_getdata, + msg_getheaders, + msg_headers, + msg_inv, + msg_sendcmpct, + msg_sendheaders, + msg_tx, + NODE_NETWORK, + P2PHeaderAndShortIDs, + PrefilledTransaction, + ToHex, +) +from test_framework.mininode import ( + mininode_lock, + network_thread_start, + P2PInterface, +) from test_framework.script import CScript, OP_TRUE +from test_framework.test_framework import BitcoinTestFramework from test_framework.txtools import pad_tx +from test_framework.util import assert_equal, sync_blocks, wait_until ''' CompactBlocksTest -- test compact blocks (BIP 152) diff --git a/test/functional/p2p_feefilter.py b/test/functional/p2p_feefilter.py --- a/test/functional/p2p_feefilter.py +++ b/test/functional/p2p_feefilter.py @@ -4,11 +4,18 @@ # file COPYING or http://www.opensource.org/licenses/mit-license.php. # -from test_framework.mininode import * -from test_framework.test_framework import BitcoinTestFramework -from test_framework.util import * +from decimal import Decimal import time +from test_framework.messages import msg_feefilter +from test_framework.mininode import ( + mininode_lock, + network_thread_start, + P2PInterface, +) +from test_framework.test_framework import BitcoinTestFramework +from test_framework.util import sync_blocks, sync_mempools + ''' FeeFilterTest -- test processing of feefilter messages ''' diff --git a/test/functional/p2p_fingerprint.py b/test/functional/p2p_fingerprint.py --- a/test/functional/p2p_fingerprint.py +++ b/test/functional/p2p_fingerprint.py @@ -11,18 +11,16 @@ import time from test_framework.blocktools import (create_block, create_coinbase) -from test_framework.mininode import ( +from test_framework.messages import ( CInv, - P2PInterface, - msg_headers, msg_block, msg_getdata, msg_getheaders, - network_thread_start, - wait_until, + msg_headers, ) +from test_framework.mininode import P2PInterface, network_thread_start from test_framework.test_framework import BitcoinTestFramework -from test_framework.util import assert_equal +from test_framework.util import assert_equal, wait_until class P2PFingerprintTest(BitcoinTestFramework): diff --git a/test/functional/p2p_invalid_block.py b/test/functional/p2p_invalid_block.py --- a/test/functional/p2p_invalid_block.py +++ b/test/functional/p2p_invalid_block.py @@ -3,14 +3,20 @@ # Distributed under the MIT software license, see the accompanying # file COPYING or http://www.opensource.org/licenses/mit-license.php. -from test_framework.test_framework import ComparisonTestFramework -from test_framework.util import * -from test_framework.comptool import TestManager, TestInstance, RejectResult -from test_framework.blocktools import * -from test_framework.mininode import network_thread_start import copy import time +from test_framework.blocktools import ( + create_block, + create_coinbase, + create_transaction, +) +from test_framework.comptool import RejectResult, TestInstance, TestManager +from test_framework.messages import COIN +from test_framework.mininode import network_thread_start +from test_framework.test_framework import ComparisonTestFramework +from test_framework.util import assert_equal + ''' In this test we connect to one node over p2p, and test block requests: diff --git a/test/functional/p2p_invalid_tx.py b/test/functional/p2p_invalid_tx.py --- a/test/functional/p2p_invalid_tx.py +++ b/test/functional/p2p_invalid_tx.py @@ -3,11 +3,18 @@ # Distributed under the MIT software license, see the accompanying # file COPYING or http://www.opensource.org/licenses/mit-license.php. -from test_framework.test_framework import ComparisonTestFramework -from test_framework.comptool import TestManager, TestInstance, RejectResult -from test_framework.blocktools import * import time +from test_framework.blocktools import ( + create_block, + create_coinbase, + create_transaction, +) +from test_framework.comptool import RejectResult, TestInstance, TestManager +from test_framework.messages import COIN +from test_framework.mininode import network_thread_start +from test_framework.test_framework import ComparisonTestFramework + ''' In this test we connect to one node over p2p, and test tx requests. diff --git a/test/functional/p2p_leak.py b/test/functional/p2p_leak.py --- a/test/functional/p2p_leak.py +++ b/test/functional/p2p_leak.py @@ -10,9 +10,16 @@ This test connects to a node and sends it a few messages, trying to intice it into sending us something it shouldn't.""" -from test_framework.mininode import * +import time + +from test_framework.mininode import ( + mininode_lock, + network_thread_join, + network_thread_start, + P2PInterface, +) from test_framework.test_framework import BitcoinTestFramework -from test_framework.util import * +from test_framework.util import wait_until banscore = 10 diff --git a/test/functional/p2p_mempool.py b/test/functional/p2p_mempool.py --- a/test/functional/p2p_mempool.py +++ b/test/functional/p2p_mempool.py @@ -3,9 +3,10 @@ # Distributed under the MIT software license, see the accompanying # file COPYING or http://www.opensource.org/licenses/mit-license.php. -from test_framework.mininode import * +from test_framework.messages import msg_mempool +from test_framework.mininode import network_thread_start, P2PInterface from test_framework.test_framework import BitcoinTestFramework -from test_framework.util import * +from test_framework.util import assert_equal class P2PMempoolTests(BitcoinTestFramework): diff --git a/test/functional/p2p_node_network_limited.py b/test/functional/p2p_node_network_limited.py --- a/test/functional/p2p_node_network_limited.py +++ b/test/functional/p2p_node_network_limited.py @@ -8,10 +8,28 @@ and that it responds to getdata requests for blocks correctly: - send a block within 288 + 2 of the tip - disconnect peers who request blocks older than that.""" -from test_framework.messages import CInv, msg_getdata, msg_verack -from test_framework.mininode import NODE_BLOOM, NODE_NETWORK_LIMITED, NODE_BITCOIN_CASH, P2PInterface, wait_until, mininode_lock, network_thread_start, network_thread_join +from test_framework.messages import ( + CInv, + msg_getdata, + msg_verack, + NODE_BITCOIN_CASH, + NODE_BLOOM, + NODE_NETWORK_LIMITED, +) +from test_framework.mininode import ( + mininode_lock, + network_thread_join, + network_thread_start, + P2PInterface, +) from test_framework.test_framework import BitcoinTestFramework -from test_framework.util import assert_equal, disconnect_nodes, connect_nodes_bi, sync_blocks +from test_framework.util import ( + assert_equal, + connect_nodes_bi, + disconnect_nodes, + sync_blocks, + wait_until, +) class P2PIgnoreInv(P2PInterface): diff --git a/test/functional/p2p_sendheaders.py b/test/functional/p2p_sendheaders.py --- a/test/functional/p2p_sendheaders.py +++ b/test/functional/p2p_sendheaders.py @@ -84,10 +84,25 @@ Expect: disconnect. """ -from test_framework.mininode import * -from test_framework.test_framework import BitcoinTestFramework -from test_framework.util import * from test_framework.blocktools import create_block, create_coinbase +from test_framework.messages import ( + CBlockHeader, + CInv, + msg_block, + msg_getblocks, + msg_getdata, + msg_getheaders, + msg_headers, + msg_inv, + msg_sendheaders, +) +from test_framework.mininode import ( + mininode_lock, + network_thread_start, + P2PInterface, +) +from test_framework.test_framework import BitcoinTestFramework +from test_framework.util import assert_equal, sync_blocks, wait_until direct_fetch_response_time = 0.05 diff --git a/test/functional/p2p_timeouts.py b/test/functional/p2p_timeouts.py --- a/test/functional/p2p_timeouts.py +++ b/test/functional/p2p_timeouts.py @@ -23,9 +23,9 @@ from time import sleep -from test_framework.mininode import * +from test_framework.messages import msg_ping +from test_framework.mininode import network_thread_start, P2PInterface from test_framework.test_framework import BitcoinTestFramework -from test_framework.util import * class TestNode(P2PInterface): diff --git a/test/functional/p2p_unrequested_blocks.py b/test/functional/p2p_unrequested_blocks.py --- a/test/functional/p2p_unrequested_blocks.py +++ b/test/functional/p2p_unrequested_blocks.py @@ -3,11 +3,34 @@ # Distributed under the MIT software license, see the accompanying # file COPYING or http://www.opensource.org/licenses/mit-license.php. -from test_framework.mininode import * -from test_framework.test_framework import BitcoinTestFramework -from test_framework.util import * +import os import time -from test_framework.blocktools import create_block, create_coinbase, create_transaction + +from test_framework.blocktools import ( + create_block, + create_coinbase, + create_transaction, +) +from test_framework.messages import ( + CBlockHeader, + CInv, + msg_block, + msg_headers, + msg_inv, +) +from test_framework.mininode import ( + mininode_lock, + network_thread_join, + network_thread_start, + P2PInterface, +) +from test_framework.test_framework import BitcoinTestFramework +from test_framework.util import ( + assert_equal, + assert_raises_rpc_error, + connect_nodes, + sync_blocks, +) ''' AcceptBlockTest -- test processing of unrequested blocks.