Page MenuHomePhabricator

Changed vMatch naming in merkleblock.* to more accurately reflect its use.
AbandonedPublic

Authored by nakihito on Mar 5 2019, 01:10.

Details

Reviewers
deadalnix
jasonbcox
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Renamed vMatch variables to more accurately reflect their use. Addresses T361.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
FixvMatchNaming
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5140
Build 8343: Bitcoin ABC Teamcity Staging
Build 8342: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 5 2019, 01:10
Owners added a reviewer: Restricted Owners Package.Mar 5 2019, 01:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 5 2019, 01:10
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Mar 5 2019, 14:47

So this clearly raise a lot more question than it answer. This seems to be using a soup of TxId and TxHash, yet the type used is always uint256. I suspect that it's neither because this include merkle path. This seems to make thing more confusing rather than anything else.

src/merkleblock.h
87

This is clearly not a mask of transaction ids.

96

Are these txhash or txid ? Or something plain hashes ? If these are TxId or TxHash, why is that a vector of uint256 then ?

130

dito

139

dito

This revision now requires changes to proceed.Mar 5 2019, 14:47
nakihito abandoned this revision.Mar 9 2019, 00:32