Renamed vMatch variables to more accurately reflect their use. Addresses T361.
Details
Details
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- FixvMatchNaming
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5140 Build 8343: Bitcoin ABC Buildbot (legacy) Build 8342: arc lint + arc unit
Event Timeline
Comment Actions
So this clearly raise a lot more question than it answer. This seems to be using a soup of TxId and TxHash, yet the type used is always uint256. I suspect that it's neither because this include merkle path. This seems to make thing more confusing rather than anything else.
src/merkleblock.h | ||
---|---|---|
87 | This is clearly not a mask of transaction ids. | |
96 | Are these txhash or txid ? Or something plain hashes ? If these are TxId or TxHash, why is that a vector of uint256 then ? | |
130 | dito | |
139 | dito |