Page MenuHomePhabricator

Changed DEFAULT_MAX_MEMPOOL_SIZE to bytes rather than megabytes.
AbandonedPublic

Authored by nakihito on Tue, Mar 5, 20:31.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Changed DEFAULT_MAX_MEMPOOL_SIZE to bytes rather than megabytes. Also adjusted uses of this constant to reflect this change. Addresses T478.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
MaxMempoolSizetoBytes
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5155
Build 8373: Bitcoin ABC Teamcity Staging
Build 8372: arc lint + arc unit

Event Timeline

nakihito created this revision.Tue, Mar 5, 20:31
Owners added a reviewer: Restricted Owners Package.Tue, Mar 5, 20:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Mar 5, 20:31
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Tue, Mar 5, 20:46

This will fuck up the configuration of everyone. What's the benefit ?

This revision now requires changes to proceed.Tue, Mar 5, 20:46
nakihito abandoned this revision.Sat, Mar 9, 00:32