Page MenuHomePhabricator
Differential D2665

Remove the public contructor for Amount
AbandonedPublic
Actions

Authored by deadalnix on Mar 7 2019, 16:49.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Summary

It's the last part of the public API that rely on a specific binary representation.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
amountnoctor
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5173
Build 8409: Bitcoin ABC Buildbot (legacy)
Build 8408: arc lint + arc unit

Event Timeline

deadalnix created this revision.Mar 7 2019, 16:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 7 2019, 16:49
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Mar 7 2019, 16:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5173: Diff 7630.Mar 7 2019, 17:04
teamcity added a comment.Mar 7 2019, 17:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox requested changes to this revision.Mar 7 2019, 18:21
jasonbcox added a subscriber: jasonbcox.

The constructor that was moved is already private and made public despite you saying the public constructor was removed.

This revision now requires changes to proceed.Mar 7 2019, 18:21
deadalnix abandoned this revision.Mar 9 2019, 00:20

I'm stupid.

Revision Contents
Changeset List

PathSize
src/
6 lines

Diff 7630

View Options

src/amount.h

Loading...