Page MenuHomePhabricator

Fix feerate coin control
ClosedPublic

Authored by jasonbcox on Mar 12 2019, 17:40.

Details

Summary

Fixes failing rpc_fundrawtransaction test on master due to botched backport D2673
Initially, it was thought that the entirety of the CoinControl block in GetMinimumFee was not needed since we're
not backporting the RBF and other fee-rated controls. However, this missed the case where this block was removed
from wallet.cpp and did not have a replacement:

if (coinControl && coinControl->fOverrideFeeRate) {
    nFeeNeeded = coinControl->nFeeRate.GetFeeCeiling(nBytes);
}
Test Plan

make check
test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Defensive check on m_feerate

This revision is now accepted and ready to land.Mar 12 2019, 18:51
This revision was automatically updated to reflect the committed changes.