diff --git a/src/test/DoS_tests.cpp b/src/test/DoS_tests.cpp --- a/src/test/DoS_tests.cpp +++ b/src/test/DoS_tests.cpp @@ -96,7 +96,8 @@ peerLogic->FinalizeNode(config, dummyNode1.GetId(), dummy); } -void AddRandomOutboundPeer(const Config &config, std::vector &vNodes, +void AddRandomOutboundPeer(const Config &config, + std::vector> &vNodes, PeerLogicValidation &peerLogic) { CAddress addr(ip(GetRandInt(0xffffffff)), NODE_NONE); vNodes.emplace_back(new CNode(id++, ServiceFlags(NODE_NETWORK), 0, @@ -123,7 +124,7 @@ options.nMaxFeeler = 1; connman->Init(options); - std::vector vNodes; + std::vector> vNodes; // Mock some outbound peers for (int i = 0; i < nMaxOutbound; ++i) { @@ -133,7 +134,7 @@ peerLogic->CheckForStaleTipAndEvictPeers(consensusParams); // No nodes should be marked for disconnection while we have no extra peers - for (const CNode *node : vNodes) { + for (auto const &node : vNodes) { BOOST_CHECK(node->fDisconnect == false); } @@ -145,7 +146,7 @@ BOOST_CHECK(connman->GetTryNewOutboundPeer()); // Still no peers should be marked for disconnection - for (const CNode *node : vNodes) { + for (auto const &node : vNodes) { BOOST_CHECK(node->fDisconnect == false); } @@ -175,7 +176,7 @@ BOOST_CHECK(vNodes.back()->fDisconnect == false); bool dummy; - for (const CNode *node : vNodes) { + for (auto const &node : vNodes) { peerLogic->FinalizeNode(config, node->GetId(), dummy); }