Page MenuHomePhabricator

[CMAKE] Fix missing protobuf include directory
ClosedPublic

Authored by Fabien on May 13 2019, 08:06.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC116f9831e6c5: [CMAKE] Fix missing protobuf include directory
Summary

The Protobuf include directory has been mistakenly removed in D3016.

This patch reverts the previous wrong change.

Full explanation:
The include directories are automatically added by CMake when using
target_link_libraries on IMPORTED target, but this is not the case
here. IMPORTED targets have been added for protobuf in later CMake
versions, past our minimum required one.

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja
./src/qt/bitcoin-qt # Sanity check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.May 13 2019, 08:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2019, 08:06
deadalnix accepted this revision.May 15 2019, 18:43
This revision is now accepted and ready to land.May 15 2019, 18:43
This revision was automatically updated to reflect the committed changes.