Page MenuHomePhabricator

[CMAKE] Disable OpenGL in Qt static build for OSX
ClosedPublic

Authored by Fabien on May 13 2019, 10:23.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC3c8b87cf3dda: [CMAKE] Disable OpenGL in Qt static build for OSX
Summary

A bug in the CMake files distributed by Qt prevent building with static
OpenGL on OSX (hard linked dependency to the framework in the Qt5Gui
dependencies). To workaround the issue, the static Qt is built without
the OpenGL support.

This fixes the bitcoin-qt cross build for OSX.

Depends on D3017 and D3033 (for the test plan).

Test Plan
mkdir buildcmake && cd buildcmake
cmake -GNinja -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/OSX.cmake ..
ninja

Run the generated src/qt/bitcoin-qt on OSX >= 10.8 (tested on OSX Sierra
10.12.6).

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.May 13 2019, 10:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 13 2019, 10:23
deadalnix accepted this revision.May 14 2019, 13:22
This revision is now accepted and ready to land.May 14 2019, 13:22
This revision was automatically updated to reflect the committed changes.