Page MenuHomePhabricator

Merge #11742: rpc: Add testmempoolaccept

Authored by markblundeberg on May 21 2019, 01:34.



PR11742 backport
b55555d rpc: Add testmempoolaccept (MarcoFalke)

also follow-up mini PR
PR12860 backport
fafcad3 doc: Add testmempoolaccept to release-notes (MarcoFalke)

Pull request description:

To check if a single raw transaction makes it into the current transaction pool, one had to call `sendrawtransaction`. However, on success, this adds the transaction to the mempool with no easy way to undo.

The call `testmempoolaccept` is introduced to provide a way to solely check the result without changing the mempool state.

Modifications for ABC:

  • include fLimitFree param (like sendrawtransaction) and remove RBF
  • adapt rpc tests:
    • no RBF test
    • +1 input in large transaction test (to ensure OVER 1 MB)
    • rpc messages "bad-tx-coinbase" and "bad-txns-nonfinal"

Depends on D3075 and D3078 and D3093

Test Plan

make check

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

incorporate small follow-up PR12860 too

markblundeberg edited the summary of this revision. (Show Details)
deadalnix requested changes to this revision.May 22 2019, 00:00
deadalnix added inline comments.
825 ↗(On Diff #8772)

There is one other callsite, so it might be worth making the code similar to core instead of adding more customization.

This revision now requires changes to proceed.May 22 2019, 00:00
markblundeberg marked an inline comment as done.
markblundeberg edited the summary of this revision. (Show Details)

address comment: rebase onto D3093

This revision is now accepted and ready to land.May 23 2019, 15:31