diff --git a/doc/developer-notes.md b/doc/developer-notes.md --- a/doc/developer-notes.md +++ b/doc/developer-notes.md @@ -508,6 +508,12 @@ - *Rationale*: Shorter and simpler header files are easier to read, and reduce compile time +- Use only the lowercase alphanumerics (`a-z0-9`), underscore (`_`) and hyphen (`-`) in source code filenames. + + - *Rationale*: `grep`:ing and auto-completing filenames is easier when using a consistent + naming pattern. Potential problems when building on case-insensitive filesystems are + avoided when using only lowercase characters in source code filenames. + - Don't import anything into the global namespace (`using namespace ...`). Use fully specified types such as `std::string`. diff --git a/src/Makefile.bench.include b/src/Makefile.bench.include --- a/src/Makefile.bench.include +++ b/src/Makefile.bench.include @@ -18,7 +18,7 @@ bench/cashaddr.cpp \ bench/checkblock.cpp \ bench/checkqueue.cpp \ - bench/Examples.cpp \ + bench/examples.cpp \ bench/rollingbloom.cpp \ bench/crypto_aes.cpp \ bench/crypto_hash.cpp \ diff --git a/src/Makefile.test.include b/src/Makefile.test.include --- a/src/Makefile.test.include +++ b/src/Makefile.test.include @@ -62,7 +62,7 @@ test/crypto_tests.cpp \ test/cuckoocache_tests.cpp \ test/dbwrapper_tests.cpp \ - test/DoS_tests.cpp \ + test/denialofservice_tests.cpp \ test/dstencode_tests.cpp \ test/excessiveblock_tests.cpp \ test/feerate_tests.cpp \ @@ -99,7 +99,7 @@ test/scheduler_tests.cpp \ test/schnorr_tests.cpp \ test/script_commitment_tests.cpp \ - test/script_P2SH_tests.cpp \ + test/script_p2sh_tests.cpp \ test/script_standard_tests.cpp \ test/script_tests.cpp \ test/scriptflags.h \ diff --git a/src/bench/CMakeLists.txt b/src/bench/CMakeLists.txt --- a/src/bench/CMakeLists.txt +++ b/src/bench/CMakeLists.txt @@ -45,7 +45,7 @@ checkqueue.cpp crypto_aes.cpp crypto_hash.cpp - Examples.cpp + examples.cpp gcs_filter.cpp lockedpool.cpp mempool_eviction.cpp diff --git a/src/bench/Examples.cpp b/src/bench/examples.cpp rename from src/bench/Examples.cpp rename to src/bench/examples.cpp diff --git a/src/net_processing.cpp b/src/net_processing.cpp --- a/src/net_processing.cpp +++ b/src/net_processing.cpp @@ -667,7 +667,7 @@ } // namespace // This function is used for testing the stale tip eviction logic, see -// DoS_tests.cpp +// denialofservice_tests.cpp void UpdateLastBlockAnnounceTime(NodeId node, int64_t time_in_seconds) { LOCK(cs_main); CNodeState *state = State(node); diff --git a/src/test/CMakeLists.txt b/src/test/CMakeLists.txt --- a/src/test/CMakeLists.txt +++ b/src/test/CMakeLists.txt @@ -75,7 +75,7 @@ crypto_tests.cpp cuckoocache_tests.cpp dbwrapper_tests.cpp - DoS_tests.cpp + denialofservice_tests.cpp dstencode_tests.cpp excessiveblock_tests.cpp feerate_tests.cpp @@ -111,7 +111,7 @@ scheduler_tests.cpp schnorr_tests.cpp script_commitment_tests.cpp - script_P2SH_tests.cpp + script_p2sh_tests.cpp script_standard_tests.cpp script_tests.cpp scriptflags.cpp diff --git a/src/test/DoS_tests.cpp b/src/test/denialofservice_tests.cpp rename from src/test/DoS_tests.cpp rename to src/test/denialofservice_tests.cpp --- a/src/test/DoS_tests.cpp +++ b/src/test/denialofservice_tests.cpp @@ -43,7 +43,7 @@ void UpdateLastBlockAnnounceTime(NodeId node, int64_t time_in_seconds); -BOOST_FIXTURE_TEST_SUITE(DoS_tests, TestingSetup) +BOOST_FIXTURE_TEST_SUITE(denialofservice_tests, TestingSetup) // Test eviction of an outbound peer whose chain never advances // Mock a node connection, and use mocktime to simulate a peer which never sends diff --git a/src/test/script_P2SH_tests.cpp b/src/test/script_p2sh_tests.cpp rename from src/test/script_P2SH_tests.cpp rename to src/test/script_p2sh_tests.cpp --- a/src/test/script_P2SH_tests.cpp +++ b/src/test/script_p2sh_tests.cpp @@ -47,7 +47,7 @@ &err); } -BOOST_FIXTURE_TEST_SUITE(script_P2SH_tests, BasicTestingSetup) +BOOST_FIXTURE_TEST_SUITE(script_p2sh_tests, BasicTestingSetup) BOOST_AUTO_TEST_CASE(sign) { LOCK(cs_main);