Page MenuHomePhabricator
Differential D3664

[qt] receive tab: bech32 address opt-in checkbox
ClosedPublic
Actions

Authored by deadalnix on Jul 12 2019, 16:52.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING58bcb91efc72: [qt] receive tab: bech32 address opt-in checkbox
rABC58bcb91efc72: [qt] receive tab: bech32 address opt-in checkbox
Summary

When launched with -adresstype=legacy the checkbox will be hidden.

This is a partial backport of Core PR11991 . The UI is not actually changed and getDefaultAddressType has been restored as PR10244 was improperly backported.

Test Plan
make check

Run bitcoin-qt and ensure the interface wasn't changed after clicking the recieve tab.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jul 12 2019, 16:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 12 2019, 16:52
teamcity added a comment.Jul 12 2019, 16:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B6838: Diff 10261!Jul 12 2019, 16:54
teamcity added a comment.Jul 12 2019, 16:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix added a child revision: D3665: wallet: Change output type globals to members.Jul 12 2019, 17:15
teamcity added a comment.Jul 12 2019, 20:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B6838: Diff 10261.Jul 12 2019, 20:49
teamcity added a comment.Jul 12 2019, 20:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Jul 15 2019, 16:51
This revision is now accepted and ready to land.Jul 15 2019, 16:51
Closed by commit rABC58bcb91efc72: [qt] receive tab: bech32 address opt-in checkbox (authored by Sjors Provoost <sjors@sprovoost.nl>, committed by deadalnix). · Explain WhyJul 15 2019, 19:17
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC58bcb91efc72: [qt] receive tab: bech32 address opt-in checkbox.
deadalnix added a commit: rSTAGING58bcb91efc72: [qt] receive tab: bech32 address opt-in checkbox.Sep 19 2019, 01:16

Revision Contents
Changeset List

PathSize
src/
interfaces/
3 lines
1 line
qt/
4 lines
10 lines
4 lines
5 lines

Diff 10299

View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/qt/addresstablemodel.h

Loading...
View Options

src/qt/addresstablemodel.cpp

Loading...
View Options

src/qt/editaddressdialog.cpp

Loading...
View Options

src/qt/receivecoinsdialog.cpp

Loading...