diff --git a/src/test/scriptnum_tests.cpp b/src/test/scriptnum_tests.cpp --- a/src/test/scriptnum_tests.cpp +++ b/src/test/scriptnum_tests.cpp @@ -43,10 +43,7 @@ CScriptNum scriptnum(num); BOOST_CHECK(verify(bignum, scriptnum)); - std::vector vch = bignum.getvch(); - CScriptNum10 bignum2(bignum.getvch(), false); - vch = scriptnum.getvch(); CScriptNum scriptnum2(scriptnum.getvch(), false); BOOST_CHECK(verify(bignum2, scriptnum2)); @@ -103,10 +100,9 @@ const CScriptNum10 bignum2(num2); const CScriptNum scriptnum1(num1); const CScriptNum scriptnum2(num2); - bool invalid = false; // int64_t overflow is undefined. - invalid = + bool invalid = ((num2 > 0 && num1 < std::numeric_limits::min() + num2) || (num2 < 0 && num1 > std::numeric_limits::max() + num2)); if (!invalid) {