Page MenuHomePhabricator
Differential D3684

Merge #11626: rpc: Make `logging` RPC public
ClosedPublic
Actions

Authored by nakihito on Jul 16 2019, 22:51.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGca5cfcef0609: Merge #11626: rpc: Make `logging` RPC public
rABCca5cfcef0609: Merge #11626: rpc: Make `logging` RPC public
Summary

cabff7588 rpc: Make logging RPC public (Wladimir J. van der Laan)

Pull request description:

This started out as a developer hack but now it's useful enough for general use. Unhide the call by moving it to `control` category. This makes it documented in `help`.

Tree-SHA512: f45fa378558b552d4e2a110bf85100b0eaaa6180bb5f62cb54a251f66026d4625b670c69d85c281eebbf4b56b80b65618c51a5a593b8f9d0a04b31e95adc91f4

Backport of Core PR11626
https://github.com/bitcoin/bitcoin/pull/11626/

Depends on D3464

Test Plan
make check
./bitcoind
./bitcoin-cli help

The logging rpc should appear under the Control section.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jul 16 2019, 22:51
Owners added a reviewer: Restricted Owners Package.Jul 16 2019, 22:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 16 2019, 22:51
teamcity added a comment.Jul 16 2019, 22:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 16 2019, 22:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6874: Diff 10330.Jul 16 2019, 22:57
jasonbcox accepted this revision.Jul 16 2019, 23:00
This revision is now accepted and ready to land.Jul 16 2019, 23:00
nakihito added a child revision: D3699: Merge #11191: RPC: Improve help text and behavior of RPC-logging..Aug 7 2019, 23:31
Closed by commit rABCca5cfcef0609: Merge #11626: rpc: Make `logging` RPC public (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyOct 17 2019, 17:42
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCca5cfcef0609: Merge #11626: rpc: Make `logging` RPC public.
nakihito added a commit: rSTAGINGca5cfcef0609: Merge #11626: rpc: Make `logging` RPC public.Apr 7 2020, 21:26

Revision Contents
Changeset List

PathSize
src/
rpc/
2 lines

Diff 13591

View Options

src/rpc/misc.cpp

Loading...