Page MenuHomePhabricator
Differential D3696

Merge #10036: Fix init README format to render correctly on github
AbandonedPublic
Actions

Authored by nakihito on Jul 18 2019, 21:39.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

b99fbad Fix init README format to render correctly on github (Jameson Lopp)

Tree-SHA512: 52b8ed9661e48e830c9e0c0e9aa670fe8d1a3848426d2d854494b477a9926f286d87e0586c2bc63f433136f8e5acd2cab3ab1f616380fb517c5a8f9d34ed52da

Backport of Core PR10036:
https://github.com/bitcoin/bitcoin/pull/10036/

Test Plan

see Core's README: https://github.com/bitcoin/bitcoin/tree/master/contrib/init
vs our README: https://github.com/Bitcoin-ABC/bitcoin-abc/tree/master/contrib/init

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR10036
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6889
Build 11825: Bitcoin ABC Buildbot (legacy)
Build 11824: arc lint + arc unit

Event Timeline

nakihito created this revision.Jul 18 2019, 21:39
Owners added a reviewer: Restricted Owners Package.Jul 18 2019, 21:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 18 2019, 21:39
nakihito planned changes to this revision.Jul 18 2019, 21:39
teamcity added a comment.Jul 18 2019, 21:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Jul 18 2019, 21:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6889: Diff 10352.Jul 18 2019, 21:49
nakihito requested review of this revision.Jul 19 2019, 17:34
deadalnix accepted this revision.Jul 20 2019, 00:06
This revision is now accepted and ready to land.Jul 20 2019, 00:06
deadalnix requested changes to this revision.Jul 20 2019, 00:07

Mention PR12345 int he description.

This revision now requires changes to proceed.Jul 20 2019, 00:07
nakihito edited the summary of this revision. (Show Details)Jul 20 2019, 00:29
nakihito requested review of this revision.Aug 20 2019, 18:39
In D3696#87223, @deadalnix wrote:

Mention PR12345 int he description.

The PR number is already in the description.

jasonbcox accepted this revision.Aug 20 2019, 19:01
Fabien accepted this revision.Aug 21 2019, 09:26
deadalnix accepted this revision.Aug 28 2019, 14:17
This revision is now accepted and ready to land.Aug 28 2019, 14:17
nakihito abandoned this revision.Aug 28 2019, 18:02

I guess this was landed as D3843 while this was waiting for review.

Revision Contents
Changeset List

PathSize
contrib/
init/
4 lines

Diff 10352

View Options

contrib/init/README.md

Loading...