Differential D3779

Tests: add usage note to check-rpc-mappings.py
ClosedPublic
Actions

Authored by Fabien on Jul 31 2019, 08:02.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGc6982e5954ac: Tests: add usage note to check-rpc-mappings.py
rABCc6982e5954ac: Tests: add usage note to check-rpc-mappings.py

Summary

This test would previously fail without a user-friendly warning message,
if invoked with no arguments.

Backport of core PR13707
https://github.com/bitcoin/bitcoin/pull/13707/files

Depends on D3772.

Also updated the copyright so the file is in sync with core.

Test Plan

./test/lint/check-rpc-mappings.py

Should return:

Usage: ./test/lint/check-rpc-mappings.py ROOT-DIR

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 31 2019, 08:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 31 2019, 08:02

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7011: Diff 10539.Jul 31 2019, 08:08

deadalnix accepted this revision.Aug 1 2019, 06:16

This revision is now accepted and ready to land.Aug 1 2019, 06:16

Closed by commit rABCc6982e5954ac: Tests: add usage note to check-rpc-mappings.py (authored by Mason Simon <masonsimon@gmail.com>, committed by Fabien). · Explain WhyAug 5 2019, 07:11

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc6982e5954ac: Tests: add usage note to check-rpc-mappings.py.

Fabien added a commit: rSTAGINGc6982e5954ac: Tests: add usage note to check-rpc-mappings.py.Sep 19 2019, 01:35

Revision Contents
Changeset List

Path

Size

test/

lint/

check-rpc-mappings.py

6 lines

Diff 10593

test/lint/check-rpc-mappings.py

Loading...