Page MenuHomePhabricator
Differential D3801

[CMAKE] Use plural form when multiple arguments are expected
ClosedPublic
Actions

Authored by Fabien on Aug 5 2019, 14:27.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGb7e198b65478: [CMAKE] Use plural form when multiple arguments are expected
rABCb7e198b65478: [CMAKE] Use plural form when multiple arguments are expected
Summary

Some add_xxx_flag() functions can actually take multiple flags are
argument. Rename them to add_xxx_flags() (note the 's') makes it
clearer and more consistent with other function names.

There is no behavior change.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Aug 5 2019, 14:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 5 2019, 14:27
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Aug 5 2019, 14:27

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Aug 5 2019, 14:33

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7042: Diff 10608.Aug 5 2019, 14:33
Fabien added a child revision: D3802: [CMAKE] Refactor the AddCompilerFlags facilities.Aug 5 2019, 15:13
jasonbcox accepted this revision.Aug 5 2019, 20:52
This revision is now accepted and ready to land.Aug 5 2019, 20:52
Closed by commit rABCb7e198b65478: [CMAKE] Use plural form when multiple arguments are expected (authored by Fabien). · Explain WhyAug 6 2019, 09:05
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCb7e198b65478: [CMAKE] Use plural form when multiple arguments are expected.
Fabien mentioned this in D3855: Fix missing plural form from commit reversal.Aug 12 2019, 16:12
Fabien mentioned this in rABC36d8a89db509: Fix missing plural form from commit reversal.Aug 13 2019, 07:56
Fabien added a commit: rSTAGINGb7e198b65478: [CMAKE] Use plural form when multiple arguments are expected.Sep 19 2019, 01:39
Fabien mentioned this in rSTAGING36d8a89db509: Fix missing plural form from commit reversal.Sep 19 2019, 01:47

Revision Contents
Changeset List

PathSize
cmake/
modules/
12 lines
src/
34 lines
leveldb/
4 lines
secp256k1/
4 lines

Diff 10630

View Options

cmake/modules/AddCompilerFlags.cmake

Loading...
View Options

src/CMakeLists.txt

Loading...
View Options

src/leveldb/CMakeLists.txt

Loading...
View Options

src/secp256k1/CMakeLists.txt

Loading...