diff --git a/test/functional/feature_cltv.py b/test/functional/feature_cltv.py --- a/test/functional/feature_cltv.py +++ b/test/functional/feature_cltv.py @@ -17,7 +17,6 @@ ToHex, ) from test_framework.mininode import ( - mininode_lock, network_thread_start, P2PInterface, ) @@ -31,7 +30,7 @@ ) from test_framework.test_framework import BitcoinTestFramework from test_framework.txtools import pad_tx -from test_framework.util import assert_equal, wait_until +from test_framework.util import assert_equal CLTV_HEIGHT = 1351 @@ -141,19 +140,11 @@ block = create_block(tip, create_coinbase(CLTV_HEIGHT), block_time) block.nVersion = 3 block.solve() - self.nodes[0].p2p.send_and_ping(msg_block(block)) - assert_equal(int(self.nodes[0].getbestblockhash(), 16), tip) - - wait_until(lambda: "reject" in self.nodes[0].p2p.last_message.keys(), - lock=mininode_lock) - with mininode_lock: - assert_equal( - self.nodes[0].p2p.last_message["reject"].code, REJECT_OBSOLETE) - assert_equal( - self.nodes[0].p2p.last_message["reject"].reason, b'bad-version(0x00000003)') - assert_equal( - self.nodes[0].p2p.last_message["reject"].data, block.sha256) - del self.nodes[0].p2p.last_message["reject"] + + with self.nodes[0].assert_debug_log(expected_msgs=['{}, bad-version(0x00000003)'.format(block.hash)]): + self.nodes[0].p2p.send_and_ping(msg_block(block)) + assert_equal(int(self.nodes[0].getbestblockhash(), 16), tip) + self.nodes[0].p2p.sync_with_ping() self.log.info( "Test that invalid-according-to-cltv transactions cannot appear in a block") @@ -201,23 +192,10 @@ block.hashMerkleRoot = block.calc_merkle_root() block.solve() - self.nodes[0].p2p.send_and_ping(msg_block(block)) - # This block is invalid - assert_equal(self.nodes[0].getbestblockhash(), tip) - - wait_until(lambda: "reject" in self.nodes[0].p2p.last_message.keys(), - lock=mininode_lock) - with mininode_lock: - assert self.nodes[0].p2p.last_message["reject"].code in [ - REJECT_INVALID, REJECT_NONSTANDARD] - assert_equal( - self.nodes[0].p2p.last_message["reject"].data, block.sha256) - if self.nodes[0].p2p.last_message["reject"].code == REJECT_INVALID: - # Generic rejection when a block is invalid - assert_equal( - self.nodes[0].p2p.last_message["reject"].reason, b'blk-bad-inputs') - else: - assert b'Negative locktime' in self.nodes[0].p2p.last_message["reject"].reason + with self.nodes[0].assert_debug_log(expected_msgs=['ConnectBlock {} failed (blk-bad-inputs'.format(block.hash)]): + self.nodes[0].p2p.send_and_ping(msg_block(block)) + assert_equal(self.nodes[0].getbestblockhash(), tip) + self.nodes[0].p2p.sync_with_ping() self.log.info( "Test that a version 4 block with a valid-according-to-CLTV transaction is accepted")