Page MenuHomePhabricator

Merge #12920: test: Fix sign for expected values

Authored by nakihito on Aug 15 2019, 18:57.


Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project

c55aa4f test: Fix sign for expected values (Karl-Johan Alm)

Pull request description:

A number of `BOOST_CHECK_EQUAL` calls would result in warnings about signs.

This PR fixes signedness for all expectation values, sometimes resulting in `int` → `unsigned int`. No other code changes besides adding/removing `U` to/from values.

Running `make &> make_output_...` on master versus on this PR:
$ wc make_output_*
    1464    5925   90357 make_output_master
     613    1469   28370 make_output_signfixed
More than halves the output lines from compiling.

Tree-SHA512: b06c9fb81704fd32a6a61fe7b2ceb5f1bb381e9873d79e13d7e4d26bbd9b67c9725a84e6fb2903bcda775aea2a792e544b0799d36735c19f5d1c7225e8c6d14e

Backport of Core PR12920

Depends on D3689

Test Plan
make check

Diff Detail

rABC Bitcoin ABC
Lint OK
No Unit Test Coverage
Build Status
Buildable 7160
Build 12365: Bitcoin ABC Buildbot (legacy)
Build 12364: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 15 2019, 18:57
Owners added a reviewer: Restricted Owners Package.Aug 15 2019, 18:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 15 2019, 18:57
Fabien accepted this revision.Aug 16 2019, 08:33
This revision is now accepted and ready to land.Aug 16 2019, 08:33
nakihito planned changes to this revision.EditedSep 18 2019, 15:57

Going to separate the the code into two parts: the code that can be landed without dependencies and the code that is dependent on D3689.

nakihito abandoned this revision.Sep 24 2019, 23:35

See D4104 for independent changes.