Differential D3882

Merge #12920: test: Fix sign for expected values
AbandonedPublic
Actions

Authored by nakihito on Aug 15 2019, 18:57.

Tags

None

Subscribers

None

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

c55aa4f test: Fix sign for expected values (Karl-Johan Alm)

Pull request description:

A number of `BOOST_CHECK_EQUAL` calls would result in warnings about signs.

This PR fixes signedness for all expectation values, sometimes resulting in `int` → `unsigned int`. No other code changes besides adding/removing `U` to/from values.

Running `make &> make_output_...` on master versus on this PR:
```
$ wc make_output_*
    1464    5925   90357 make_output_master
     613    1469   28370 make_output_signfixed
```
More than halves the output lines from compiling.

Tree-SHA512: b06c9fb81704fd32a6a61fe7b2ceb5f1bb381e9873d79e13d7e4d26bbd9b67c9725a84e6fb2903bcda775aea2a792e544b0799d36735c19f5d1c7225e8c6d14e

Backport of Core PR12920
https://github.com/bitcoin/bitcoin/pull/12920/

Depends on D3689

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12920

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7160
Build 12365: Bitcoin ABC Buildbot (legacy)
Build 12364: arc lint + arc unit

Event Timeline

nakihito created this revision.Aug 15 2019, 18:57

Owners added a reviewer: Restricted Owners Package.Aug 15 2019, 18:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 15 2019, 18:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7160: Diff 10810.Aug 15 2019, 19:06

Fabien accepted this revision.Aug 16 2019, 08:33

This revision is now accepted and ready to land.Aug 16 2019, 08:33

Going to separate the the code into two parts: the code that can be landed without dependencies and the code that is dependent on D3689.

nakihito mentioned this in D4104: Partial Merge #12920: test: Fix sign for expected values.Sep 18 2019, 19:49

Nico Guiton <nico@bitframe.org> mentioned this in rABCacc1dbbebdfc: Partial Merge #12920: test: Fix sign for expected values.Sep 19 2019, 17:27

See D4104 for independent changes.

Nico Guiton <nico@bitframe.org> mentioned this in rSTAGINGacc1dbbebdfc: Partial Merge #12920: test: Fix sign for expected values.Sep 27 2019, 22:45

Revision Contents
Changeset List

Path

Size

src/

test/

addrman_tests.cpp

66 lines

allocator_tests.cpp

4 lines

bloom_tests.cpp

2 lines

coins_tests.cpp

6 lines

crypto_tests.cpp

4 lines

dbwrapper_tests.cpp

6 lines

32 lines

merkleblock_tests.cpp

14 lines

8 lines

random_tests.cpp

2 lines

script_standard_tests.cpp

24 lines

serialize_tests.cpp

54 lines

torcontrol_tests.cpp

4 lines

txvalidationcache_tests.cpp

6 lines

wallet/

test/

wallet_tests.cpp

18 lines

Diff 10810

src/test/addrman_tests.cpp

Loading...

src/test/allocator_tests.cpp

Loading...

src/test/bloom_tests.cpp

Loading...

src/test/coins_tests.cpp

Loading...

src/test/crypto_tests.cpp

Loading...

src/test/dbwrapper_tests.cpp

Loading...

src/test/hash_tests.cpp

Loading...

src/test/merkleblock_tests.cpp

Loading...

src/test/pow_tests.cpp

Loading...

src/test/random_tests.cpp

Loading...

src/test/script_standard_tests.cpp

Loading...

src/test/serialize_tests.cpp

Loading...

src/test/torcontrol_tests.cpp

Loading...

src/test/txvalidationcache_tests.cpp

Loading...

src/wallet/test/wallet_tests.cpp

Loading...