Page MenuHomePhabricator

Added empty block fallback to CreateNewBlock
Needs ReviewPublic

Authored by jasonbcox on Mon, Sep 9, 20:02.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

This provides a damage-control mechanism when invalid blocks are being erroneously generated for a new block template. While this is not bullet-proof against all conceivable bugs, it protects miners against issues with transaction inclusion, ordering, etc.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
empty-block-fallback-gbt-default
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7370
Build 12783: Bitcoin ABC Teamcity Staging
Build 12782: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Mon, Sep 9, 20:02
jasonbcox planned changes to this revision.Mon, Sep 9, 20:05
jasonbcox updated this revision to Diff 11171.Mon, Sep 9, 20:28

Changed tests to call CreateNewBlock() with default params in as many places as possible. Improve existing tests so that a fallback empty block will not accidentally pass.